Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: staging legacyInteg test fail #1175

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: staging legacyInteg test fail #1175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/phoenix/virtual-server-loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,14 @@ function _isServiceWorkerLoaderPage() {
const indexUrl = `${location.origin}/index.html`,
baseUrl = `${location.origin}/`,
devURL = 'http://localhost:8000/src/',
distTestURL = 'http://localhost:8000/dist-test/src/',
playwrightDevURL = 'http://localhost:5000/src/',
playwrightDistTestURL = 'http://localhost:5000/dist-test/src/',
currentURL = _getBaseURL();
console.log("currentURL", currentURL, indexUrl, baseUrl, devURL);
return (currentURL === baseUrl || currentURL === indexUrl || currentURL === devURL ||
(currentURL === playwrightDevURL && window.Phoenix.browser.desktop.isChromeBased));
return (currentURL === baseUrl || currentURL === indexUrl || currentURL === devURL || currentURL === distTestURL ||
(currentURL === playwrightDevURL && window.Phoenix.browser.desktop.isChromeBased) ||
(currentURL === playwrightDistTestURL && window.Phoenix.browser.desktop.isChromeBased));
// we dont spawn virtual server in iframe playwright linux/safari as playwright linux/safari fails badly
// we dont need virtual server for tests except for live preview and custom extension load tests,
// which are disabled in playwright. We test in chrome atleast as chromium support is a baseline.
Expand Down