fix: keybindings unit test fialures

phcode-dev · Jan 1, 2024 · 20c2a17 · 20c2a17
1 parent 167163f
commit 20c2a17
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 10 deletions.
diff --git a/docs/generatedApiDocs/utils/FeatureGate-API.md b/docs/generatedApiDocs/utils/FeatureGate-API.md
@@ -89,6 +89,15 @@ if(FeatureGate.isFeatureEnabled(FEATURE_NEW_COLORS)){
 
 Returns **[boolean][3]** 
 
+## setFeatureEnabled
+
+Sets the enabled state of a specific feature in the application.
+
+### Parameters
+
+*   `featureName` **[string][2]** The name of the feature to be modified.
+*   `isEnabled` **[boolean][3]** A boolean flag indicating whether the feature should be enabled (true) or disabled (false).
+
 [1]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Statements/function
 
 [2]: https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/String

diff --git a/test/spec/KeyBindingManager-test-files/duplicateShortcuts.json b/test/spec/KeyBindingManager-test-files/duplicateShortcuts.json
@@ -1,8 +1,8 @@
 {
     "documentation": "https://github.com/adobe/brackets/wiki/Key-Bindings",
     "overrides": {
-        "ctrl-2": "file.openFolder",
-        "Ctrl-2": "file.openFolder",
+        "ctrl-2": "file.newFile",
+        "Ctrl-2": "file.newFile",
         "Ctrl-Alt-4": "view.toggleSidebar",
         "Alt-Ctrl-4": "view.toggleSidebar"
     } 

diff --git a/test/spec/KeyBindingManager-test-files/keymap.json b/test/spec/KeyBindingManager-test-files/keymap.json
@@ -1,7 +1,7 @@
 {
     "documentation": "https://github.com/adobe/brackets/wiki/Key-Bindings",
     "overrides": {
-        "ctrl-2": "file.openFolder",
+        "ctrl-2": "file.newFile",
         "Alt-Ctrl-Backspace": "view.toggleSidebar",
         "ctrl-l": "navigate.gotoDefinition",
         "Alt-Ctrl-L": null

diff --git a/test/spec/KeyBindingManager-test-files/macKeymap.json b/test/spec/KeyBindingManager-test-files/macKeymap.json
@@ -1,7 +1,7 @@
 {
     "documentation": "https://github.com/adobe/brackets/wiki/Key-Bindings",
     "overrides": {
-        "ctrl-2": "file.openFolder",
+        "ctrl-2": "file.newFile",
         "Alt-Cmd-Backspace": "view.toggleSidebar",
         "ctrl-l": "navigate.gotoDefinition",
         "Alt-Cmd-L": null

diff --git a/test/spec/KeyBindingManager-test.js b/test/spec/KeyBindingManager-test.js
@@ -49,7 +49,7 @@ define(function (require, exports, module) {
             "Alt-Shift-Down": "edit.addCursorToNextLine",
             "Alt-Shift-Up": "edit.addCursorToPrevLine",
             "F8": "navigate.gotoFirstProblem",
-            "Ctrl-Alt-O": "file.openFolder",
+            "Ctrl-1": "file.newFile",
             "Ctrl-Alt-H": "view.toggleSidebar",
             "Ctrl-Shift-O": "navigate.quickOpen",
             "Ctrl-T": "navigate.gotoDefinition"
@@ -60,7 +60,7 @@ define(function (require, exports, module) {
             "Alt-Shift-Down": "edit.addCursorToNextLine",
             "Alt-Shift-Up": "edit.addCursorToPrevLine",
             "Cmd-'": "navigate.gotoFirstProblem",
-            "Alt-Cmd-O": "file.openFolder",
+            "Cmd-1": "file.newFile",
             "Shift-Cmd-H": "view.toggleSidebar",
             "Shift-Cmd-O": "navigate.quickOpen",
             "Cmd-T": "navigate.gotoDefinition"
@@ -618,7 +618,7 @@ define(function (require, exports, module) {
                     called = true;
                     var msgPrefix = Strings.ERROR_NONEXISTENT_COMMANDS.replace("{0}", "");
                     expect(message).toMatch(msgPrefix);
-                    expect(message).toMatch("file.openFolder");
+                    expect(message).toMatch("file.newFile");
                     expect(message).toMatch("view.toggleSidebar");
                     return {done: function (callback) { callback(Dialogs.DIALOG_BTN_OK); } };
                 };
@@ -652,7 +652,7 @@ define(function (require, exports, module) {
                 let reassignedKey1 = (platform === "mac") ? "Alt-Cmd-Backspace" : "Ctrl-Alt-Backspace",
                     reassignedKey2 = (platform === "mac") ? "Cmd-T" : "Ctrl-T";
                 expect(called).toBeFalse();
-                expect(keymap["Ctrl-2"].commandID).toEqual("file.openFolder");
+                expect(keymap["Ctrl-2"].commandID).toEqual("file.newFile");
                 expect(keymap["Alt-Cmd-O"]).toBeFalsy();
                 expect(keymap["Alt-Ctrl-O"]).toBeFalsy();
 
@@ -692,7 +692,7 @@ define(function (require, exports, module) {
 
                 var keymap = KeyBindingManager.getKeymap(),
                     reassignedKey1 = (platform === "mac") ? "Alt-Cmd-Backspace" : "Ctrl-Alt-Backspace",
-                    reassignedKey2 = (platform === "mac") ? "Alt-Cmd-O" : "Ctrl-Alt-O",
+                    reassignedKey2 = "Ctrl-1",
                     reassignedKey3 = (platform === "mac") ? "Alt-Cmd-L" : "Ctrl-Alt-L";
 
                 expect(called).toBeFalse();
@@ -702,7 +702,7 @@ define(function (require, exports, module) {
                 expect(keymap[reassignedKey1]).toBeFalsy();
 
                 // Default key binding for "file.openFolder" is restored.
-                expect(keymap[reassignedKey2].commandID).toEqual("file.openFolder");
+                expect(keymap[reassignedKey2].commandID).toEqual("file.newFile");
 
                 expect(keymap["Ctrl-L"].commandID).toEqual("navigate.gotoDefinition");
                 expect(keymap[reassignedKey3]).toBeFalsy();