Fix CI and remove Ring2 dependency #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Start to migrate to Ring from Pharo - Remove deprecated calls - Improve a tear down that is brittle
|
In order to do this change I had to change things in Pharo itself to improve Ring and it seems that the changes did not made it into SmalltalkCI used images yet |
MarcusDenker
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix the CI. It seems to work on my local copy of Iceberg, now let's see what the CI says.
I removed the replacement of Spec and Tonel in the pre load script because this is not needed and buggy. I also removed the used of the external Ring for tests and use the Ring version in the Pharo image instead.
I also removed some scripts and made sure all scripts were in the same place