Skip to content

Commit

Permalink
Take Martin's comment into account
Browse files Browse the repository at this point in the history
  • Loading branch information
jecisc committed Nov 21, 2023
1 parent 7a04662 commit fc689b9
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/sync-wiki.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
name: Sync GitHub Wiki from Sources
steps:
- run: ./.github/scripts/sync-wiki.sh
- run: ./scripts/sync-wiki.sh
env:
GH_PERSONAL_ACCESS_TOKEN: ${{ secrets.GH_PERSONAL_ACCESS_TOKEN }}
shell: bash
Expand Down
4 changes: 2 additions & 2 deletions .smalltalk.ston
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SmalltalkCISpec {
#name: 'Iceberg',
#preLoading: '.github/scripts/preLoading.st',
#postLoading: '.github/scripts/postLoading.st',
#preLoading: 'scripts/preLoading.st',
#postLoading: 'scripts/postLoading.st',
#loading : [
SCIMetacelloLoadSpec {
#baseline : 'Iceberg',
Expand Down
4 changes: 2 additions & 2 deletions .smalltalk.windows.ston
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
SmalltalkCISpec {
#name: 'Iceberg',
#preLoading: '.github/scripts/preLoading.st',
#postLoading: '.github/scripts/postLoading.st',
#preLoading: 'scripts/preLoading.st',
#postLoading: 'scripts/postLoading.st',
#loading : [
SCIMetacelloLoadSpec {
#baseline : 'Iceberg',
Expand Down
8 changes: 4 additions & 4 deletions docs/Contributing-to-Iceberg.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ To do that, it's needed to create a pull request to one of the following branche

Loading Iceberg in Pharo is more difficult than updating other projects -that just use a "Metacello script"- since normally Metacello will rely on Iceberg to update Iceberg.

That's the reason to have [a bash update script](../.github/scripts/testUpdateIceberg.sh) that performs some pre- and post-load actions.
That's the reason to have [a bash update script](../scripts/testUpdateIceberg.sh) that performs some pre- and post-load actions.
Steps to use it:
1. Open a terminal
2. Clone this repository and checkout the desired branch
3. Execute `./.github/scripts/testUpdateIceberg.sh --dev`
3. Execute `./scripts/testUpdateIceberg.sh --dev`
4. Execute `./pharo-ui Pharo.image`

Also, the script loads the `development` Metacello group, which contains some tests that are not present in the Pharo image normally.
Expand All @@ -30,14 +30,14 @@ About Windows platform, we know it worked in the MINGW64 Bash Console that came

## Contributions to Wiki

We count with [a bash script](../.github/scripts/sync-wiki.sh) that deploys the markdown files in `doc/` directory to the Wiki section.
We count with [a bash script](../scripts/sync-wiki.sh) that deploys the markdown files in `doc/` directory to the Wiki section.
The entry point for the wiki is the [Home page](Home.md).

A while ago, Travis CI executed such bash script each time the `master` branch changed.
This is not working for the moment, but contributors can execute the following command in a terminal:

```bash
export GH_TOKEN=<<TOKEN>> && ./.github/scripts/sync-wiki.sh
export GH_TOKEN=<<TOKEN>> && ./scripts/sync-wiki.sh
```
where `<<TOKEN>>` is a [GitHub Personal Token](https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token) with repo:write permissions on this repository.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 comments on commit fc689b9

Please sign in to comment.