Merge pull request #1846 from Rinzwind/method-history-browse-commit

we merge and fix the code quality test later

Iceberg-TipUI/IceTipBrowseCommitCommand.class.st

@@ -0,0 +1,28 @@
+"
+Command that opens a Repository Browser on the selected commit.
+"
+Class {
+	#name : 'IceTipBrowseCommitCommand',
+	#superclass : 'IceTipCommand',
+	#category : 'Iceberg-TipUI-Commands',
+	#package : 'Iceberg-TipUI',
+	#tag : 'Commands'
+}
+
+{ #category : 'default' }
+IceTipBrowseCommitCommand class >> defaultName [
+
+	^ 'Browse commit'
+]
+
+{ #category : 'execution' }
+IceTipBrowseCommitCommand >> commit [
+
+	^ self item commit
+]
+
+{ #category : 'executing' }
+IceTipBrowseCommitCommand >> execute [
+
+	IceTipRepositoryBrowser openOnCommit: self commit
+]

Iceberg-TipUI/IceTipHistoryBrowser.class.st

@@ -152,6 +152,13 @@ IceTipHistoryBrowser >> refreshTags [
 	commitList refresh
 ]
 
+{ #category : 'selection' }
+IceTipHistoryBrowser >> selectCommit: commit scrollToSelection: shouldScrollToSelection [
+
+	self commitList selectIndex: (self commitList items detectIndex: [ :item | item commit = commit ])
+		scrollToSelection: shouldScrollToSelection
+]
+
 { #category : 'accessing' }
 IceTipHistoryBrowser >> selectedCommit [
 

Iceberg-TipUI/IceTipRepositoryBrowser.class.st

@@ -69,6 +69,15 @@ IceTipRepositoryBrowser class >> onRepositoryNamed: aString [
 	^ self onRepository: (IceRepository registry detect: [ :each | each name = aString ])
 ]
 
+{ #category : 'opening' }
+IceTipRepositoryBrowser class >> openOnCommit: commit [
+
+	^ (self onRepository: commit repository)
+		open;
+		selectCommit: commit scrollToSelection: true;
+		yourself
+]
+
 { #category : 'event handling' }
 IceTipRepositoryBrowser >> commitishSelected: ann [
 
@@ -155,6 +164,12 @@ IceTipRepositoryBrowser >> refreshWhenRepository: ann [
 	self updatePresenter
 ]
 
+{ #category : 'selection' }
+IceTipRepositoryBrowser >> selectCommit: commit scrollToSelection: shouldScrollToSelection [
+
+	self historyPanel selectCommit: commit scrollToSelection: shouldScrollToSelection
+]
+
 { #category : 'initialization' }
 IceTipRepositoryBrowser >> selectCurrentBranch [
 

Iceberg-TipUI/IceTipVersionHistoryBrowser.class.st

@@ -31,7 +31,7 @@ IceTipVersionHistoryBrowser class >> buildGeneralCommandGroupWith: presenter for
 { #category : 'commands' }
 IceTipVersionHistoryBrowser class >> buildSelectionCommandGroupWith: presenter for: aCommandGroup [
 
-	{ 	IceTipInstallVersionCommand }
+	{ 	IceTipInstallVersionCommand. IceTipBrowseCommitCommand }
 			do: [ :each |
 				aCommandGroup register: (each forSpecContext: presenter) ]