Merge pull request #1873 from AlexisCnockaert/ResizeWindow

Presenters in Pharo remember their last size and does not use initial extent anymore if its not first time opened
pharo-vcs · Jan 13, 2025 · 7e3023f · 7e3023f
2 parents 8cd5479 + 4431111
commit 7e3023f
Show file tree

Hide file tree

Showing 38 changed files with 215 additions and 266 deletions.
diff --git a/Iceberg-Plugin-GitHub/IceGitHubAcceptPullRequestPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubAcceptPullRequestPresenter.class.st
@@ -16,6 +16,11 @@ Class {
 	#tag : 'View'
 }
 
+{ #category : 'accessing' }
+IceGitHubAcceptPullRequestModel class >> defaultPreferredExtent [
+	^ (600 @ 300)
+]
+
 { #category : 'class initialization' }
 IceGitHubAcceptPullRequestPresenter class >> initialize [
 
@@ -62,12 +67,6 @@ IceGitHubAcceptPullRequestPresenter >> defaultType [
 	^ 'merge'
 ]
 
-{ #category : 'api' }
-IceGitHubAcceptPullRequestPresenter >> initialExtentForWindow [
-
-	^ (600 @ 300) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceGitHubAcceptPullRequestPresenter >> initializeDialogWindow: aDialogWindowPresenter [
 

diff --git a/Iceberg-Plugin-GitHub/IceGitHubCreatePullRequestPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubCreatePullRequestPresenter.class.st
@@ -31,6 +31,11 @@ Class {
 	#tag : 'View'
 }
 
+{ #category : 'accessing' }
+IceGitHubCreatePullRequestModel class >> defaultPreferredExtent [
+	^ (700 @ 300)
+]
+
 { #category : 'class initialization' }
 IceGitHubCreatePullRequestPresenter class >> initialize [
 
@@ -251,13 +256,7 @@ IceGitHubCreatePullRequestPresenter >> headRemote [
 ]
 
 { #category : 'initialization' }
-IceGitHubCreatePullRequestPresenter >> initialExtentForWindow [
-
-	^ (700 @ 300) scaledByDisplayScaleFactor
-]
-
-{ #category : 'initialization' }
-IceGitHubCreatePullRequestPresenter >> initializeDialogWindow: aWindow [
+IceGitHubCreatePullRequestModel >> initializeDialogWindow: aWindow [
 
 	aWindow
 		addButton: 'Cancel' do: [ :presenter | 

diff --git a/Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st b/Iceberg-Plugin-GitHub/IceGitHubNewBranchFromIssuePanel.class.st
@@ -23,6 +23,13 @@ Class {
 	#tag : 'View'
 }
 
+{ #category : 'accessing' }
+IceGitHubNewBranchFromIssuePanel class >> defaultPreferredExtent [ 
+
+
+	^ 800 @ 175
+]
+
 { #category : 'accessing' }
 IceGitHubNewBranchFromIssuePanel >> branchName [
 
@@ -56,12 +63,6 @@ IceGitHubNewBranchFromIssuePanel >> icon [
 	^ (self iconNamed: #github) scaledToSize: 16@16
 ]
 
-{ #category : 'initialization' }
-IceGitHubNewBranchFromIssuePanel >> initialExtentForWindow [
-
-	^ 800 @ 175
-]
-
 { #category : 'initialization' }
 IceGitHubNewBranchFromIssuePanel >> initialize [
 

diff --git a/Iceberg-Plugin-GitHub/IceGitHubRejectPullRequestPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubRejectPullRequestPresenter.class.st
@@ -15,6 +15,11 @@ Class {
 	#tag : 'View'
 }
 
+{ #category : 'accessing' }
+IceGitHubRejectPullRequestModel class >> defaultPreferredExtent [
+	^ (500 @ 250)
+]
+
 { #category : 'class initialization' }
 IceGitHubRejectPullRequestPresenter class >> initialize [
 
@@ -58,12 +63,6 @@ IceGitHubRejectPullRequestPresenter >> defaultType [
 	^ 'merge'
 ]
 
-{ #category : 'api' }
-IceGitHubRejectPullRequestPresenter >> initialExtentForWindow [
-
-	^ (500 @ 250) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceGitHubRejectPullRequestPresenter >> initializeDialogWindow: aDialogWindowPresenter [
 

diff --git a/Iceberg-Plugin-GitHub/IceGitHubRemoveBranchesPresenter.class.st b/Iceberg-Plugin-GitHub/IceGitHubRemoveBranchesPresenter.class.st
@@ -16,6 +16,13 @@ Class {
 	#tag : 'View'
 }
 
+{ #category : 'accessing' }
+IceGitHubRemoveBranchesModel class >> defaultPreferredExtent [ 
+
+
+	^ 550 @ 500
+]
+
 { #category : 'class initialization' }
 IceGitHubRemoveBranchesPresenter class >> initialize [
 
@@ -45,13 +52,7 @@ IceGitHubRemoveBranchesPresenter >> displayBlock: aBlock [
 ]
 
 { #category : 'initialization' }
-IceGitHubRemoveBranchesPresenter >> initialExtentForWindow [
-
-	^ 550 @ 500
-]
-
-{ #category : 'initialization' }
-IceGitHubRemoveBranchesPresenter >> initialize [
+IceGitHubRemoveBranchesModel >> initialize [
 
 	selectedItems := Set new.
 	super initialize

diff --git a/Iceberg-Plugin-GitHub/IceGitHubTipPullRequestBrowser.class.st b/Iceberg-Plugin-GitHub/IceGitHubTipPullRequestBrowser.class.st
@@ -37,6 +37,11 @@ IceGitHubTipPullRequestBrowser class >> buildSelectionCommandGroupWith: presente
 	"Nothing to add"
 ]
 
+{ #category : 'accessing' }
+IceGitHubTipPullRequestBrowser class >> defaultPreferredExtent [
+	^ (1050 @ 800)
+]
+
 { #category : 'instance creation' }
 IceGitHubTipPullRequestBrowser class >> newApplication: app model: aModel pullRequest: aPullRequest [
 
@@ -121,12 +126,6 @@ IceGitHubTipPullRequestBrowser >> diff [
 	^ diff
 ]
 
-{ #category : 'initialization' }
-IceGitHubTipPullRequestBrowser >> initialExtentForWindow [
-
-	^ (1050 @ 800) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceGitHubTipPullRequestBrowser >> initializeCommitsTable [
 

diff --git a/Iceberg-Plugin-GitHub/IceTipGitHubPullRequestListBrowser.class.st b/Iceberg-Plugin-GitHub/IceTipGitHubPullRequestListBrowser.class.st
@@ -43,6 +43,11 @@ IceTipGitHubPullRequestListBrowser class >> buildSelectionCommandGroupWith: pres
 
 ]
 
+{ #category : 'accessing' }
+IceTipGitHubPullRequestListBrowser class >> defaultPreferredExtent [
+	^ (700 @ 700)
+]
+
 { #category : 'instance creation' }
 IceTipGitHubPullRequestListBrowser class >> onRepository: aRepository [
 
@@ -95,12 +100,6 @@ IceTipGitHubPullRequestListBrowser >> fetchPullRequests [
 				yourself ]
 ]
 
-{ #category : 'initialization' }
-IceTipGitHubPullRequestListBrowser >> initialExtentForWindow [
-
-	^ (700 @ 700) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipGitHubPullRequestListBrowser >> initializePresenters [
 

diff --git a/Iceberg-Plugin-Migration/IceTipFiletreeToTonelDialogPresenter.class.st b/Iceberg-Plugin-Migration/IceTipFiletreeToTonelDialogPresenter.class.st
@@ -17,6 +17,12 @@ Class {
 	#tag : 'UI'
 }
 
+{ #category : 'accessing' }
+IceTipFiletreeToTonelDialogPresenter class >> defaultPreferredExtent [
+
+	^ 500 @ (self inputTextHeight * 5 + self buttonHeight + 50)
+]
+
 { #category : 'actions' }
 IceTipFiletreeToTonelDialogPresenter >> accept [
 
@@ -88,14 +94,6 @@ IceTipFiletreeToTonelDialogPresenter >> iconPanel [
 	^ iconPanel
 ]
 
-{ #category : 'initialization' }
-IceTipFiletreeToTonelDialogPresenter >> initialExtentForWindow [
-
-	^ (500
-	   @ (self class inputTextHeight * 5 + self class buttonHeight + 50))
-		  scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipFiletreeToTonelDialogPresenter >> initializePresenters [
 

diff --git a/Iceberg-TipUI/IceTipAddPlaintextCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAddPlaintextCredentialsPresenter.class.st
@@ -13,6 +13,11 @@ Class {
 	#tag : 'Credentials'
 }
 
+{ #category : 'accessing' }
+IceTipAddPlaintextCredentialsPresenter class >> defaultPreferredExtent [
+	^ (350 @ (self  inputTextHeight * 5 + self  buttonHeight))
+]
+
 { #category : 'testing' }
 IceTipAddPlaintextCredentialsPresenter >> accept [
 
@@ -38,13 +43,6 @@ IceTipAddPlaintextCredentialsPresenter >> hostnameFromInput [
 	^ hostInput text
 ]
 
-{ #category : 'initialization' }
-IceTipAddPlaintextCredentialsPresenter >> initialExtentForWindow [
-
-	^ (350 @ (self class inputTextHeight * 5 + self class buttonHeight))
-		  scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipAddPlaintextCredentialsPresenter >> initializePresenters [
 

diff --git a/Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st b/Iceberg-TipUI/IceTipAddRemoteDialogPresenter.class.st
@@ -17,6 +17,12 @@ Class {
 	#tag : 'View-Repository'
 }
 
+{ #category : 'accessing' }
+IceTipAddRemoteDialogPresenter class >> defaultPreferredExtent [
+
+	^ 500 @ (self inputTextHeight * 2 + self buttonHeight + 50) "Yes, a magic number"
+]
+
 { #category : 'actions' }
 IceTipAddRemoteDialogPresenter >> accept [
 
@@ -43,16 +49,6 @@ IceTipAddRemoteDialogPresenter >> defaultLayout [
 
 ]
 
-{ #category : 'initialization' }
-IceTipAddRemoteDialogPresenter >> initialExtentForWindow [
-
-	^ (500@(
-		self class inputTextHeight * 2
-		+ self class buttonHeight 
-		+ 50 "Yes, a magic number"
-		)) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipAddRemoteDialogPresenter >> initializePresenters [
 

diff --git a/Iceberg-TipUI/IceTipAddSSHCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAddSSHCredentialsPresenter.class.st
@@ -13,6 +13,11 @@ Class {
 	#tag : 'Credentials'
 }
 
+{ #category : 'accessing' }
+IceTipAddSSHCredentialsPresenter class >> defaultPreferredExtent [
+	^ (350 @ (self  inputTextHeight * 7 + self buttonHeight))
+]
+
 { #category : 'actions' }
 IceTipAddSSHCredentialsPresenter >> accept [
 
@@ -39,13 +44,6 @@ IceTipAddSSHCredentialsPresenter >> hostnameFromInput [
 	^ hostInput text
 ]
 
-{ #category : 'initialization' }
-IceTipAddSSHCredentialsPresenter >> initialExtentForWindow [
-
-	^ (350 @ (self class inputTextHeight * 7 + self class buttonHeight))
-		  scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipAddSSHCredentialsPresenter >> initializePresenters [
 

diff --git a/Iceberg-TipUI/IceTipAddTokenCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAddTokenCredentialsPresenter.class.st
@@ -17,6 +17,11 @@ Class {
 	#tag : 'Credentials'
 }
 
+{ #category : 'accessing' }
+IceTipAddTokenCredentialsPresenter class >> defaultPreferredExtent [
+	^ (350 @ (self inputTextHeight * 5 + self buttonHeight))
+]
+
 { #category : 'accessing' }
 IceTipAddTokenCredentialsPresenter >> accept [
 
@@ -44,12 +49,6 @@ IceTipAddTokenCredentialsPresenter >> hostnameFromInput [
 	^ hostInput text
 ]
 
-{ #category : 'initialization' }
-IceTipAddTokenCredentialsPresenter >> initialExtentForWindow [
-
-	^ (350 @ (self class inputTextHeight * 5 + self class buttonHeight)) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipAddTokenCredentialsPresenter >> initializePresenters [
 

diff --git a/Iceberg-TipUI/IceTipAskForPlaintextCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAskForPlaintextCredentialsPresenter.class.st
@@ -10,6 +10,11 @@ Class {
 	#tag : 'Credentials'
 }
 
+{ #category : 'accessing' }
+IceTipAskForPlaintextCredentialsPresenter class >> defaultPreferredExtent [
+	^ (450 @ 180)
+]
+
 { #category : 'actions' }
 IceTipAskForPlaintextCredentialsPresenter >> accept [
 
@@ -46,12 +51,6 @@ IceTipAskForPlaintextCredentialsPresenter >> defaultLayout [
 
 ]
 
-{ #category : 'initialization' }
-IceTipAskForPlaintextCredentialsPresenter >> initialExtentForWindow [
-
-	^ (450 @ 180) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipAskForPlaintextCredentialsPresenter >> titleForWindow [
 

diff --git a/Iceberg-TipUI/IceTipAskForPlaintextOtpCredentialsPresenter.class.st b/Iceberg-TipUI/IceTipAskForPlaintextOtpCredentialsPresenter.class.st
@@ -10,6 +10,11 @@ Class {
 	#tag : 'Credentials'
 }
 
+{ #category : 'accessing' }
+IceTipAskForPlaintextOtpCredentialsPresenter class >> defaultPreferredExtent [
+	^ (350 @ 210)
+]
+
 { #category : 'layout' }
 IceTipAskForPlaintextOtpCredentialsPresenter >> defaultLayout [
 
@@ -28,12 +33,6 @@ IceTipAskForPlaintextOtpCredentialsPresenter >> defaultLayout [
 		yourself
 ]
 
-{ #category : 'initialization' }
-IceTipAskForPlaintextOtpCredentialsPresenter >> initialExtentForWindow [
-
-	^ (350 @ 210) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipAskForPlaintextOtpCredentialsPresenter >> initializePresenters [
 

diff --git a/Iceberg-TipUI/IceTipBrowser.class.st b/Iceberg-TipUI/IceTipBrowser.class.st
@@ -63,6 +63,11 @@ IceTipBrowser class >> buildSelectionExtraCommandGroupWith: presenter for: aComm
 	aCommandGroup register: (IceFiletreeToTonelCommand forSpecContext: presenter)
 ]
 
+{ #category : 'accessing' }
+IceTipBrowser class >> defaultPreferredExtent [
+	^ (600 @ 400)
+]
+
 { #category : 'commands' }
 IceTipBrowser class >> generalCommandGroupName [
 
@@ -120,12 +125,6 @@ IceTipBrowser >> iconForWindow [
 	^ self iconNamed: #komitterSmalltalkhubRemote
 ]
 
-{ #category : 'initialization' }
-IceTipBrowser >> initialExtentForWindow [
-
-	^ (600 @ 400) scaledByDisplayScaleFactor
-]
-
 { #category : 'initialization' }
 IceTipBrowser >> initialize [