Merge pull request #1814 from pharo-vcs/dev-2.0

minor fixes
pharo-vcs · Apr 8, 2024 · 4cdc21d · 4cdc21d
2 parents 80860aa + ffc9ba4
commit 4cdc21d
Show file tree

Hide file tree

Showing 6 changed files with 32 additions and 4 deletions.
diff --git a/Iceberg-Tests/IceBasicRepositoryFixture.class.st b/Iceberg-Tests/IceBasicRepositoryFixture.class.st
@@ -26,6 +26,13 @@ IceBasicRepositoryFixture class >> inMemory [
 		yourself
 ]
 
+{ #category : 'private' }
+IceBasicRepositoryFixture >> deleteAllForcingClose [
+
+	self repository free. 
+	super deleteAllForcingClose
+]
+
 { #category : 'initialization' }
 IceBasicRepositoryFixture >> initialize [
 	super initialize.

diff --git a/Iceberg-Tests/IceClonedFromRemoteFixture.class.st b/Iceberg-Tests/IceClonedFromRemoteFixture.class.st
@@ -12,6 +12,13 @@ Class {
 	#tag : 'Common-Fixtures'
 }
 
+{ #category : 'private' }
+IceClonedFromRemoteFixture >> deleteAllForcingClose [
+
+	self repository free. 
+	super deleteAllForcingClose
+]
+
 { #category : 'accessing' }
 IceClonedFromRemoteFixture >> pushRepository [
 	^ pushRepository

diff --git a/Iceberg-Tests/IceGitTestFactory.class.st b/Iceberg-Tests/IceGitTestFactory.class.st
@@ -109,6 +109,7 @@ IceGitTestFactory >> tearDownWithRepository: aRepository [
 
 	aRepository ifNotNil: [
 		aRepository free.
+		Smalltalk garbageCollect.
 		[ aRepository location ifNotNil: #ensureDeleteAll ]
 			on: CannotDeleteFileException
 			do: [ "On windows it is possible we need to finalize everything before deleting the files. We do not do it directly to avoid to lose too much speed"

diff --git a/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st b/Iceberg-Tests/IceNotYetClonedRepositoryFixture.class.st
@@ -30,6 +30,15 @@ IceNotYetClonedRepositoryFixture class >> inMemory [
 		yourself
 ]
 
+{ #category : 'private' }
+IceNotYetClonedRepositoryFixture >> deleteAllForcingClose [
+	"On windows it is possible we need to finalize everything before deleting the files. 
+	 We do not do it directly to avoid to lose too much speed"
+
+	Smalltalk garbageCollect.
+	self location ifNotNil: #ensureDeleteAll
+]
+
 { #category : 'initialization' }
 IceNotYetClonedRepositoryFixture >> ensureRemoteRepository [
 
@@ -111,7 +120,8 @@ IceNotYetClonedRepositoryFixture >> tearDown [
 
 	[ self location ifNotNil: #ensureDeleteAll ]
 		on: CannotDeleteFileException
-		do: [ "On windows it is possible we need to finalize everything before deleting the files. We do not do it directly to avoid to lose too much speed"
-			Smalltalk garbageCollect.
-			self location ifNotNil: #ensureDeleteAll ]
+		do: [ 
+			"On windows it is possible we need to finalize everything before deleting the files. 
+			 We do not do it directly to avoid to lose too much speed"
+			self deleteAllForcingClose ]
 ]
diff --git a/Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st b/Iceberg-TipUI/IceTipInteractiveErrorVisitor.class.st
@@ -58,7 +58,8 @@ IceTipInteractiveErrorVisitor >> repository: anObject [
 
 { #category : 'visiting' }
 IceTipInteractiveErrorVisitor >> visitAuthenticationError: anError [
-	context application
+
+	context application newInform
 		label: anError messageText;
 		title: 'Iceberg authentication Error';
 		openModal

diff --git a/Iceberg-UI-Tests/IceTipCommitBrowserTest.class.st b/Iceberg-UI-Tests/IceTipCommitBrowserTest.class.st
@@ -39,6 +39,7 @@ IceTipCommitBrowserTest >> setUp [
 
 { #category : 'running' }
 IceTipCommitBrowserTest >> tearDown [
+
 	presenter ifNotNil: [ presenter window close ].
 	super tearDown 
 ]
@@ -154,6 +155,7 @@ IceTipCommitBrowserTest >> testIsCommittingWithTheRightMessage [
 { #category : 'tests' }
 IceTipCommitBrowserTest >> testIsNotAutomaticallySavingWhenNotChecked [
 	| previousState |
+
 	previousState := presenter commentPanel isSaving.
 	presenter commentPanel saveOnCommit: false.
 	[