-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement some explicitly required methods to speed up shapes #53
Conversation
- Do something only when the roassal canvas hasAnimation - Avoid unneeded calculations
Fixed BigVisualization examples
…sue #51, “Roassal ‘Demo’ window is blank after reopening image”).
Make #createSurface on RSAthensMorph invalidate the canvas
#explicitRequirement is really slow in the case were a method is implemented already in the superclass and this slow down a lot some visualizations. I propose to explicitly define the super call to get a huge speed up on shapes (This allows to save a lot of times in the Moose visualizations)
Can we remove explicit requirement instead? |
Personally I like to have those methods because it means "Those methods needs to be there for the trait to work" like we have But if asked to, I can remove them. |
I know you like them but they do not fit with our world. |
If traits were more intelligent and not install methods defined in superclasses, would that solve your problem? This of course means that adding a method in a class should recompute the "subclass responsibility/requirements" in subclasses. Alternatively how would you feel if the classes importing a trait do never import explicit requirement methods? This means, the explicit requirement is in the trait to express the requirement, but it's not installed/compiled/copied into the class, thus producing a DNU at runtime (which is not different from the requirement error). |
Those were options we talked about with Pablo and I'm fine with both. We just did not start this work because it requires time |
I like the second one more than the first one (did not think a lot about them). |
#explicitRequirement is really slow in the case were a method is implemented already in the superclass and this slow down a lot some visualizations. I propose to explicitly define the super call to get a huge speed up on shapes (This allows to save a lot of times in the Moose visualizations)