Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up around tasks #448

Merged
merged 7 commits into from
Mar 2, 2024
Merged

Clean up around tasks #448

merged 7 commits into from
Mar 2, 2024

Conversation

tinchodias
Copy link
Collaborator

We are not listening these signals, and they make the code more difficult to comprehend. I'd remove them similarly what we did with telemetry in #439

@tinchodias tinchodias changed the title Clean up tasks Clean up some task signals Feb 21, 2024
@tinchodias tinchodias changed the base branch from master to dev February 22, 2024 13:24
@tinchodias
Copy link
Collaborator Author

@plantec In my most recent commit, I simplified repeated task. I tried these uses:

  • ToExperiments class>>#example_rotationAnimation
  • ToSandBox class>>#example_toLabelWithTime
    And Album examples, for the blinking cursor.

The example with fork works now

@plantec
Copy link
Collaborator

plantec commented Feb 26, 2024

cool, I like all the cleaning.
"The example with fork works now", do you mean without BlTaskAction use ?

@tinchodias
Copy link
Collaborator Author

cool, I like all the cleaning. "The example with fork works now", do you mean without BlTaskAction use ?

yes, without need of BlTaskAction. However, I think its better to use BlTaskAction.

@tinchodias
Copy link
Collaborator Author

This closes #449

@tinchodias tinchodias merged commit e2bc8f9 into dev Mar 2, 2024
8 of 12 checks passed
@tinchodias tinchodias deleted the CleanUpTasks branch March 2, 2024 03:41
@tinchodias tinchodias changed the title Clean up some task signals Clean up around tasks Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants