fix alignLeftAt: alignRightAt: to better fit the implementation of Vertical Alignment

[Enzo-Demeulenaere]

I spotted this issue while in a call with @tinchodias, where in the BlClickEventExamplesTest>>threeElementsWithFalseChildClipping, the placement of elements would not feel right when reading alignRightAt: and alignTopAt: .

I noticed that Vertical Alignment used "BlVerticalCoordinateTopAlignment" and "BlVerticalCoordinateBottomAlignment" while Horizontal Alignment used only "BlHorizontalCoordinateStartAlignment" (while also not having any method alignLeftAt: when dealing with ignored layout)

I propose this fix that matches the implementation of Vertical alignment, describing my methods as such :

alignLeftAt: Align the left of the element horizontally with a unit-coordinate inside of the parent, going from left to right

alignRightAt: "Align the right of the element horizontally with a unit-coordinate inside of the parent, going from right to left"

[tinchodias]

@Enzo-Demeulenaere thanks for the change.

Maybe you can add some test? I didn't check where should it be. I guess in the frame layout tests, and ignore layout tests?

What do you think?

[tinchodias]

Hi @Enzo-Demeulenaere doesn't it work keeping BlHorizontalCoordinateStartAlignment instead of BlHorizontalCoordinateLeftAlignment in this case?

Maybe @plantec has some view on this, we discussed something related to start/end left/right a time ago...

[Enzo-Demeulenaere]

Hi,

By looking at the code I would say this doesn't change anything as the coordinate: and relativeAlignment: methods are defined and called in the 'BlHorizontalCoordinateAlignment' superclass

[tinchodias]

I'm confused with this code (not the change but the whole code). This "aUnitCoordinateNumber" is probably a [0..1] ratio. I find strange the term coordinate, or am I wrong?

[tinchodias]

Wow, I see that evaluation of BlElementAlignment horizontal end returns an instance of BlHorizontalEndAlignment.

So, we were creating here an instance of BlHorizontalCoordinateStartAlignment that has a "relative alignment" of BlHorizontalEndAlignment... a horizontal coordinate start with a relative horizontal end alignment... it sounds redundant and contradictory at the same time. I'm lost of what concept is this representing.

[Enzo-Demeulenaere]

I see what you mean but now that we have a RightAlignment with an EndAlignment does this mean it goes from right to left ? or just from right to right somehow ?

[tinchodias]

I guess that if a layout were in rightToLeft mode, then start means right and end means left. But in the most usual leftToRight mode yes, start=left and end=right. But not sure how is it working.

[Enzo-Demeulenaere]

Hi @tinchodias I just added tests as well as a small cheat sheet (in Bloc-Examples) for anyone to see it when trying to understand align[Direction]At:

Here's how it looks

[tinchodias]

looks great thanks