Start using PMVector and cleaning #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jordanmontt
commented
Apr 17, 2023
•
jordanmontt
commented
- Added vector-matrix dependencie to the baseline.
- Refactored Euclidean, Hellinger, Mannhattan and Minkowski distances to use the norm of PMVector. Those algos use the norm of the vector to calculate the distance
- Improved class comment of Hellinger distance. Added explanations of why we implemented that way because the original formula has an integral and we didn't implemented like that.
- Separated Hellinger distance test into several tests. One there are 4 tests instead of 1
…nhattan and Minkowski distances to use the norm function of PMVector. Improved class comment of Hellinger distance. Separeted Hellinger distance test into several tests.
|
This also closes #34 |
jecisc
approved these changes
Apr 18, 2023
Co-authored-by: CyrilFerlicot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.