Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT - DO NOT MERGE ⚠️ feat: Reintroduce multiversion docs #2622

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cicdguy
Copy link
Collaborator

@cicdguy cicdguy commented Jan 6, 2025

Reintroduces the multiversion docs feature per @manciniedoardo's request.

The change was reverted in ee3e5b1 per @pharmaverse/admiral's decision.

This PR will reintroduce multiversion docs.

See examples where this is successfully used:

@cicdguy cicdguy self-assigned this Jan 6, 2025
@cicdguy cicdguy requested a review from jeffreyad as a code owner January 6, 2025 13:40
@cicdguy cicdguy force-pushed the feat/reintroduce-multiversion-docs branch from 6aacbbd to 859172d Compare January 6, 2025 13:41
@cicdguy
Copy link
Collaborator Author

cicdguy commented Jan 6, 2025

Weird - I don't see a "draft" option for this PR, maybe because pharmaverse is a free-tier GitHub org.

@cicdguy cicdguy changed the title feat: Reintroduce multiversion docs DRAFT: feat: Reintroduce multiversion docs Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (5318 / 5423)

Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cicdguy!! Shall I merge this in now?

We have a new CRAN release on Jan 15 be great to work out any kinks before that

@cicdguy
Copy link
Collaborator Author

cicdguy commented Jan 6, 2025

Thanks @cicdguy!! Shall I merge this in now?

We have a new CRAN release on Jan 15 be great to work out any kinks before that

Not yet - I'll need to push the past versions into the gh-pages branch. Also I'll do a full check regarding link updates across other repos as they may be referring to admiral articles whose URLs will change as a result of this.

@cicdguy cicdguy changed the title DRAFT: feat: Reintroduce multiversion docs DRAFT - DO NOT MERGE ⚠️ feat: Reintroduce multiversion docs Jan 6, 2025
@bms63
Copy link
Collaborator

bms63 commented Jan 6, 2025

Thanks @cicdguy!! Shall I merge this in now?
We have a new CRAN release on Jan 15 be great to work out any kinks before that

Not yet - I'll need to push the past versions into the gh-pages branch. Also I'll do a full check regarding link updates across other repos as they may be referring to admiral articles whose URLs will change as a result of this.

Roger! I guess that is why you wanted to set it to DRAFT! Just ping me if you want a second set of eyes or to merge in. Thanks again for making this update - I know you are in high demand!

@cicdguy
Copy link
Collaborator Author

cicdguy commented Jan 10, 2025

I'll revisit this after the upcoming release. Do not want to disrupt anything that way.

Copy link

This Pull Request is stale because it has not been worked on in 15 days.

@github-actions github-actions bot added the stale label Jan 26, 2025
@bms63
Copy link
Collaborator

bms63 commented Jan 26, 2025

@cicdguy think we can proceed with this PR now. admiral was released on January 15th with no issues identified...so far.

@bms63
Copy link
Collaborator

bms63 commented Jan 26, 2025

Will the links not be an issue once this is merged into main - the ones with cran-release are all failing.

@github-actions github-actions bot removed the stale label Jan 27, 2025
@cicdguy
Copy link
Collaborator Author

cicdguy commented Jan 30, 2025

@bms63 - yes those links will all be updated. There's some other background work required to finish this end-to-end (re-provisioning older version on gh-pages etc), so I'll keep this open until that other work has also been completed.

@manciniedoardo
Copy link
Collaborator

Update from @cicdguy: progress on this expected by end of month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants