-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: implemented relevant CI workflows from admiralci #106
Enhancement: implemented relevant CI workflows from admiralci #106
Conversation
ecd00a5
to
b0a5ab0
Compare
b0a5ab0
to
1bb2ea5
Compare
…of github.com:pharmaverse/aNCA into Enhancement-implement-CI-workflows-based-on-admiralci
5496a5f
to
0d6deda
Compare
0d6deda
to
026d358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! I saw you need 2 reviewers, not sure if I need to check anything else, but what I can confirm:
✅Re-run of the workflow produce same annotations and checks
✅ Functionalities of the App are kept after file changes (nca.R, general_lineplot.R ...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've added non-blocking comments/questions.
Issue
Closes #64
Description
Adds
.github/workflows/main.yaml
file, which will run relevant checks from admiralci repository:In addition, the workflow will also run
devtools::test()
.