Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: implemented relevant CI workflows from admiralci #106

Merged

Conversation

m-kolomanski
Copy link
Collaborator

@m-kolomanski m-kolomanski commented Oct 31, 2024

Issue

Closes #64

Description

Adds .github/workflows/main.yaml file, which will run relevant checks from admiralci repository:

  • spellcheck
  • lintr
  • man pages, checking if documentation is up to date with docstrings
  • R CMD check, with note: since we have some warnings already, I have made it so the check will pass even with warnings. In the future, once we clean those up, it would be beneficial to enable the check to fail on warnings too

In addition, the workflow will also run devtools::test().

@m-kolomanski m-kolomanski force-pushed the Enhancement-implement-CI-workflows-based-on-admiralci branch from ecd00a5 to b0a5ab0 Compare October 31, 2024 07:06
@m-kolomanski m-kolomanski force-pushed the Enhancement-implement-CI-workflows-based-on-admiralci branch from b0a5ab0 to 1bb2ea5 Compare October 31, 2024 07:08
@m-kolomanski m-kolomanski force-pushed the Enhancement-implement-CI-workflows-based-on-admiralci branch 3 times, most recently from 5496a5f to 0d6deda Compare October 31, 2024 09:43
@m-kolomanski m-kolomanski force-pushed the Enhancement-implement-CI-workflows-based-on-admiralci branch from 0d6deda to 026d358 Compare October 31, 2024 09:48
@m-kolomanski m-kolomanski requested a review from Gotfrid October 31, 2024 09:53
@Gero1999 Gero1999 self-requested a review October 31, 2024 10:21
Copy link
Collaborator

@Gero1999 Gero1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! I saw you need 2 reviewers, not sure if I need to check anything else, but what I can confirm:

✅Re-run of the workflow produce same annotations and checks
✅ Functionalities of the App are kept after file changes (nca.R, general_lineplot.R ...)

Copy link
Collaborator

@Gotfrid Gotfrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've added non-blocking comments/questions.

README.md Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@m-kolomanski m-kolomanski merged commit c8240ab into main Nov 5, 2024
9 checks passed
@m-kolomanski m-kolomanski deleted the Enhancement-implement-CI-workflows-based-on-admiralci branch January 23, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: Setup CI
3 participants