Phalcon 5 update #10
Open
Phalcon 5 update #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any updates on the status of this PR? |
|
Tests will fail, as they are runing with phalcon 4. This PR should be manually checked by maintainer |
|
Yeah, I noticed it was a pretty old PR and was hoping my activity could stimulate it. I wound up, as ugly as it is, just copy and pasting what I needed into my tests to get them to work |
|
You can use my fork meanwhile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains breaking code changes for Phalcon 5. Must be released under new major version. https://docs.phalcon.io/5.0/en/unit-testing points to ^v1.0.0-alpha.1 which is not compatible with Phalcon 5.0