Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Sequencing Run script #156

Open
wants to merge 18 commits into
base: development
Choose a base branch
from
Open

Conversation

JeffreyThiessen
Copy link
Member

@JeffreyThiessen JeffreyThiessen commented Jun 6, 2023

What does this PR do and why?

This adds a script scripts/delete_sequencing_run.sh that accepts a config file and a run directory, and deletes the associated sequencing run from IRIDA.
This is needed because sometimes high throughput users upload to the wrong project, and the data needs to be quickly removed and reuploaded.

Screenshots or screen recordings

image

How to set up and validate locally

  1. Run IRIDA
  2. Create create a sequencing client
  3. Upload a sequencing run to IRIDA
    a. Pull this branch
    b. make gui
    c. ./scripts/gui.sh
    d. open Configuration Settings and enter client/user/url details
    e. Upload some data, the example data in examples/ will work for this
    f. Verify on IRIDA that the data exists in the project
    e. Verify the Sequencing Run exists in the Admin panel
  4. run the new script without any arguments to see usage message ./scripts/delete_sequencing_run.sh
  5. run with --version to see version info ./scripts/delete_sequencing_run.sh --version
  6. run with --help to see help info ./scripts/delete_sequencing_run.sh --help
  7. run with config file and directory specified to start script
    a. default config file directory is -c ~/.config/irida-uploader/config.conf
    b. directory should be the directory you uploaded, ex: `-d examples/miseq_run
  8. Verify that the displayed files match what was uploaded
  9. Verify that you are prompted with run id to confirm deletion
  10. enter run id to delete
  11. Verify on IRIDA that the data was deleted from the project
  12. Verify on the IRIDA Admin panel that the sequencing run was deleted
  13. Run script again, but this time verifying that the run could not be found as it was deleted
  14. Upload more data, and run script again, but enter a wrong id and verify that run does not get deleted
  15. Manually edit the status file examples/miseq_run/irida_uploader_status.info, changing "Upload Status": "complete" to "Upload Status": "partial"
  16. Run script again, and verify that the script give a message about non complete run, and exits

PR acceptance checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md updated with information for new change.
  • User documentation updated for UI or technical changes.

JeffreyThiessen and others added 18 commits December 5, 2019 16:54
* fixed bash script not finding python startup file when executing from outside base directory (#54)

* fixed bash script not finding python startup file when executing from outside base directory

* bump version to 0.3.1

* fix travis and readthedocs builds for new irida dev

* update travis ci configg

* Testing java 11 in dev tests noted in changelog

* fix strings and wording

* fixed iseq runs to work with the miniseq parser

* add gui close message boxes

* changed gui close to only prompt mid upload

* log crash stack trace to logging directory on crash

* fix readthedocs link not pointing to stable build

* Fixed irida disconnect hard crash

* fix gui hard exit on first launch

* added notes about new crash logging to changelog and docs

* cleaned up code flow

* Updated config tests to match new functionality

* python 3.5 compatibility fix

* updated other RTD links in Readme to point to stable

* fixed wording in closeEvent comment block

* fix formatting issues

* fixed crash case found during crash log testing

* fixed parsing thread not catching all errors

* add note to changelog about parsing crash bugfix

* fix crash log catching to use excepthook override instead of try/catch

* added link to tutorials to readme and docs
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Coverage report

The coverage rate went from 86.7% to 86.32% ⬇️

12.5% of new lines are covered.

Diff Coverage details (click to unfold)

iridauploader/init.py

100% of new lines are covered (100% of the complete file).

iridauploader/api/api_calls.py

6.66% of new lines are covered (72.96% of the complete file).
Missing lines: 987, 989, 991, 992, 993, 994, 996, 997, 998, 999, 1000, 1002, 1004, 1005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant