-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Sequencing Run script #156
Open
JeffreyThiessen
wants to merge
18
commits into
development
Choose a base branch
from
run_delete_script
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed bash script not finding python startup file when executing from outside base directory (#54) * fixed bash script not finding python startup file when executing from outside base directory * bump version to 0.3.1 * fix travis and readthedocs builds for new irida dev * update travis ci configg * Testing java 11 in dev tests noted in changelog * fix strings and wording * fixed iseq runs to work with the miniseq parser * add gui close message boxes * changed gui close to only prompt mid upload * log crash stack trace to logging directory on crash * fix readthedocs link not pointing to stable build * Fixed irida disconnect hard crash * fix gui hard exit on first launch * added notes about new crash logging to changelog and docs * cleaned up code flow * Updated config tests to match new functionality * python 3.5 compatibility fix * updated other RTD links in Readme to point to stable * fixed wording in closeEvent comment block * fix formatting issues * fixed crash case found during crash log testing * fixed parsing thread not catching all errors * add note to changelog about parsing crash bugfix * fix crash log catching to use excepthook override instead of try/catch * added link to tutorials to readme and docs
Coverage reportThe coverage rate went from
Diff Coverage details (click to unfold)iridauploader/init.py
iridauploader/api/api_calls.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
This adds a script
scripts/delete_sequencing_run.sh
that accepts a config file and a run directory, and deletes the associated sequencing run from IRIDA.This is needed because sometimes high throughput users upload to the wrong project, and the data needs to be quickly removed and reuploaded.
Screenshots or screen recordings
How to set up and validate locally
a. Pull this branch
b.
make gui
c.
./scripts/gui.sh
d. open Configuration Settings and enter client/user/url details
e. Upload some data, the example data in
examples/
will work for thisf. Verify on IRIDA that the data exists in the project
e. Verify the Sequencing Run exists in the Admin panel
./scripts/delete_sequencing_run.sh
./scripts/delete_sequencing_run.sh --version
./scripts/delete_sequencing_run.sh --help
a. default config file directory is
-c ~/.config/irida-uploader/config.conf
b. directory should be the directory you uploaded, ex: `-d examples/miseq_run
examples/miseq_run/irida_uploader_status.info
, changing"Upload Status": "complete"
to"Upload Status": "partial"
PR acceptance checklist
Things for the developer to confirm they've done before the PR should be accepted: