Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Describe in detail what your merge request does and why.
This PR adds in the UI to edit metadata templates for projects and groups.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
Edit template dialog only enables the submit button when fields are added to the selected list and the name has a required attribute..however if a user tries to bypass these via inspect element the errors are caught and displayed in an alert:
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
[email protected]
Edit
for the templateavailable
list doesn't include theselected
itemsfields
(remove and add some) and update thename
(make note of which fields are in theselected
list)name
has updatedEdit
for the template againavailable
list doesn't include theselected
items and that theselected
items now includes the items from the selected list instep 5
, as well as thename
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.