Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Edit Metadata Template #924

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Feb 4, 2025

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR adds in the UI to edit metadata templates for projects and groups.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

image

image

image

image

Edit template dialog only enables the submit button when fields are added to the selected list and the name has a required attribute..however if a user tries to bypass these via inspect element the errors are caught and displayed in an alert:

image

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Login as [email protected]
  2. Follow the instructions in UI: Create Metadata Template #923 to create a template
  3. From the metadata templates listing, click Edit for the template
  4. Verify that the available list doesn't include the selected items
  5. Update the fields (remove and add some) and update the name (make note of which fields are in the selected list)
  6. Verify in the table listing the template name has updated
  7. Click Edit for the template again
  8. Verify that the available list doesn't include the selected items and that the selected items now includes the items from the selected list in step 5, as well as the name

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

@deepsidhu85 deepsidhu85 force-pushed the edit-metadata-template-ui branch from 9f4aca9 to 262d1e1 Compare February 4, 2025 22:00

This comment has been minimized.

@deepsidhu85 deepsidhu85 changed the title Setup edit template ui UI: Edit Metadata Template Feb 5, 2025
@deepsidhu85 deepsidhu85 marked this pull request as ready for review February 5, 2025 00:21
@deepsidhu85 deepsidhu85 self-assigned this Feb 5, 2025
@deepsidhu85 deepsidhu85 added the enhancement New feature or request label Feb 5, 2025
…es update turbo stream, updated button classes for update button, fixed bug where duplicate items were displayed in the selected list on error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant