-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch sample import service #897
base: main
Are you sure you want to change the base?
Conversation
6bb7ad9
to
b034367
Compare
This comment has been minimized.
This comment has been minimized.
b034367
to
9a49b1c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Code coverage of files in pull request scope (56.3%)Reported by octocov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base of this looks great, just have one comment for now
@spreadsheet.each_with_index(parse_settings) do |data, index| | ||
next unless index.positive? | ||
|
||
# TODO: handle metadata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking this can be done in the process_sample_row once the sample is persisted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. The metadata headers should probably be processed here with the other headers though.
b949234
to
0401de1
Compare
What does this PR do and why?
Describe in detail what your merge request does and why.
Additional fixes/changes in this pr
Note: I decided to split this PR into 2 parts, this part which handles the sample file creation and refactor, and a separate PR for doing the metadata parsing.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other pull requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
PR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.