Workflow Executions: Share results

[malchua]

What does this PR do and why?

Describe in detail what your merge request does and why.

This PR relates to STRY0016470, where we want to be able to share our workflow execution results to the project/group so that members are able to see the results. This PR covers issue #884

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other pull requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

1. Login as a user that is a member of a group.
2. Select a project within that group.
3. In the samples page for that project, create a workflow execution and check the box asking if you want to share the results with the project members.
4. After creating the workflow execution, click on the Workflow Executions section on the sidebar of that project.
5. Confirm that the workflow execution is present.
6. Log out, then login as a different member that has access to the same group (the access level must be at least an Analyst)
7. Go to the Workflow Executions page for the same project.
8. Confirm that this member is also able to see the same workflow execution.
9. Confirm that this member is not allowed to Cancel, Delete, or Edit this workflow execution.

PR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the PR acceptance checklist for this PR.

[ChrisHuynh333]

Some comments below to start and also some clarification questions (maybe geared more towards @ericenns :

1. I would think we need a Workflow Execution listing for groups now? I don't see anywhere to view a workflow that's been shared with the group
2. Should the user that created a shared workflow still be able to cancel/delete/modify the workflow from their own personal workflow listing?
3. Listing the user that created the shared workflow on the workflow summary tab?

Also, could the description header for the project workflow executions page be updated as it no longer pertains to only automated workflows:

[ericenns]

Some comments below to start and also some clarification questions (maybe geared more towards @ericenns :

1. I would think we need a Workflow Execution listing for groups now? I don't see anywhere to view a workflow that's been shared with the group
2. Should the user that created a shared workflow still be able to cancel/delete/modify the workflow from their own personal workflow listing?
3. Listing the user that created the shared workflow on the workflow summary tab?

Also, could the description header for the project workflow executions page be updated as it no longer pertains to only automated workflows:

1. Groups Workflow Executions listing will be accomplished in a separate PR.
2. Yes the user that created a shared workflow should still be able to cancel/delete/modify the workflow from their own personal workflow listing.
3. I think this could be handled in a separate PR, though maybe @deepsidhu85 would have suggestions on having a activity for this (but again that might be better as a follow up PR).

[ericenns]

Left a few comments on implementation. I have not tried creating an automated workflow execution but we should ensure that the shared_with_namespace checkbox is not shown when creating an automated workflow execution as that would be confusing to the users.

[ericenns]

nitpick (blocking): based off of comment above, this does not need to be passed in.

[malchua]

Changed in 02741a9

[ChrisHuynh333]

Some more comments below.

Maybe out of scope of this PR (@ericenns) but users with access to shared workflows are unable to export them which I imagine is part of the reason for sharing workflows?

[ChrisHuynh333]

Can you flip these (and their closing tags) so that you don't render the empty div

[malchua]

Fixed in 4628876

[malchua]

You're also correct that the other project members should be able to export. Should be fixed in 85f9079

[ChrisHuynh333]

Building on this, could you fix the path within the export preview to navigate to the workflow within the project if it's shared:

Currently it will navigate to the workflow as if it's owned by the user (which would be inaccessible), but if shared, we want to access it through the project (hopefully that makes sense).
Please also add associated UI tests for creating export from a shared workflow and clicking a shared link navigates to the expected page. There are similar tests in test/system/data_exports_test that you can draw from.

[ChrisHuynh333]

One more comment while playing around

[github-actions]

Code Metrics Report

Coverage	Test Execution Time
92.8%	10m38s

Code coverage of files in pull request scope (98.5%)

Files	Coverage
app/components/nextflow_component.html.erb	95.3%
app/components/nextflow_component.rb	100.0%
app/components/workflow_executions/table_component.html.erb	100.0%
app/components/workflow_executions/table_component.rb	100.0%
app/controllers/projects/workflow_executions_controller.rb	100.0%
app/controllers/workflow_executions/submissions_controller.rb	100.0%
app/controllers/workflow_executions_controller.rb	96.6%
app/policies/workflow_execution_policy.rb	98.4%
app/services/data_exports/create_service.rb	100.0%
app/views/projects/automated_workflow_executions/_edit_dialog.html.erb	88.8%
app/views/projects/automated_workflow_executions/_new_automated_workflow_execution_modal.html.erb	100.0%

---

Reported by octocov