Skip to content

Commit

Permalink
test: Update samples test to use metadata template select dropdown
Browse files Browse the repository at this point in the history
Modify system test to replace metadata toggle label click with select dropdown interaction, ensuring consistent test coverage for the new metadata template selection method
  • Loading branch information
joshsadam committed Feb 3, 2025
1 parent e29ced9 commit e97b192
Showing 1 changed file with 13 additions and 12 deletions.
25 changes: 13 additions & 12 deletions test/system/groups/samples_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,7 @@ def retrieve_puids
assert_selector 'th', count: 6
end

assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1
find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

assert_selector 'div#spinner'
assert_no_selector 'div#spinner'
Expand Down Expand Up @@ -448,8 +447,7 @@ def retrieve_puids
click_on 'Last Updated'
assert_selector 'table thead th:nth-child(5) svg.icon-arrow_up'

assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1
find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

assert_selector 'div#spinner'
assert_no_selector 'div#spinner'
Expand All @@ -465,22 +463,25 @@ def retrieve_puids
assert_selector 'td:nth-child(9) button', text: ''
end

find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

assert_selector 'div#spinner'
assert_no_selector 'div#spinner'

assert_selector 'table thead tr th', count: 6
end

test 'can sort samples by metadata column' do
visit group_samples_url(@group)
assert_text strip_tags(I18n.t(:'viral.pagy.limit_component.summary', from: 1, to: 20, count: 26,
locale: @user.locale))
assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')
within('table thead tr') do
assert_selector 'th', count: 6
end

find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

assert_selector 'div#spinner'
assert_no_selector 'div#spinner'

Expand All @@ -501,7 +502,8 @@ def retrieve_puids
assert_selector 'tbody tr:first-child td:nth-child(2)', text: @sample30.name

# toggling metadata again causes sort to be reset
find('label', text: I18n.t(:'projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

assert_selector 'div#spinner'
assert_no_selector 'div#spinner'

Expand Down Expand Up @@ -931,7 +933,7 @@ def retrieve_puids
test 'should partially import metadata with missing sample errors' do
visit group_samples_url(@group)

find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')
assert_selector 'div#spinner'
assert_no_selector 'div#spinner'

Expand Down Expand Up @@ -984,8 +986,7 @@ def retrieve_puids
assert_selector 'div#spinner'
assert_no_selector 'div#spinner'

assert_selector 'label', text: I18n.t('projects.samples.shared.metadata_toggle.label'), count: 1
find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

within('table thead tr') do
assert_selector 'th', count: 9
Expand Down Expand Up @@ -1022,7 +1023,7 @@ def retrieve_puids
login_as users(:ryan_doe)
visit group_samples_url(@group)

find('label', text: I18n.t('projects.samples.shared.metadata_toggle.label')).click
select(I18n.t('components.metadata_templates_dropdown.all'), from: 'q[metadata_template]')

within('table thead tr') do
assert_selector 'th', count: 9
Expand Down

0 comments on commit e97b192

Please sign in to comment.