Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Input Handling for query_ids in FILTER_QUERY Process #27

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix Input Handling for query_ids in FILTER_QUERY Process #27

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5550d2b
Fix input 'query_ids' for process
kylacochrane Sep 20, 2024
1c596b3
Update versioning and CHANGELOG documentation
kylacochrane Sep 20, 2024
07a8762
Update tag in changelog
kylacochrane Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.2.3] - 2024/09/20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding 😄. Could you add the link to this version/tag as well in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course: 07a8762


### `Changed`

- Updated `FILTER_QUERY` process to treat `query_ids` as a file input (path instead of val) for proper file path handling across environments [PR27](https://github.com/phac-nml/gasnomenclature/pull/27)
- Addressed [Issue26](https://github.com/phac-nml/gasnomenclature/issues/26)

## [0.2.2] - 2024/09/13

### `Changed`
Expand Down
2 changes: 1 addition & 1 deletion modules/local/filter_query/main.nf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ process FILTER_QUERY {
'biocontainers/csvtk:0.22.0--h9ee0642_1' }"

input:
val query_ids
path query_ids
path addresses
val in_format
val out_format
Expand Down
2 changes: 1 addition & 1 deletion nextflow.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ manifest {
description = """Gas Nomenclature assignment pipeline"""
mainScript = 'main.nf'
nextflowVersion = '!>=23.04.0'
version = '0.2.2'
version = '0.2.3'
doi = ''
defaultBranch = 'main'
}
Expand Down
Loading