Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final integration tests #15

Merged
merged 10 commits into from
Jun 20, 2024
Merged

Add final integration tests #15

merged 10 commits into from
Jun 20, 2024

Conversation

kylacochrane
Copy link
Contributor

@kylacochrane kylacochrane commented Jun 17, 2024

This PR adds the final integration tests to the gasnomenclature pipeline. These tests focus on validating the input parameters for the various processes.

This PR also updates documentation:

  • CITATIONS.md
  • LICENSE
  • CHNAGELOG.md
  • output.md

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).

@kylacochrane kylacochrane changed the base branch from main to dev June 17, 2024 17:03
@phac-nml phac-nml deleted a comment from github-actions bot Jun 17, 2024
Copy link

github-actions bot commented Jun 17, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cc8b033

+| ✅ 146 tests passed       |+
#| ❔  22 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/gasnomenclature/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/gasnomenclature/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-gasnomenclature_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-gasnomenclature_logo_dark.png
  • files_exist - File is ignored: docs/images/nf-core-gasnomenclature_logo_light.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-gasnomenclature_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-gasnomenclature_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-gasnomenclature_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/gasnomenclature/gasnomenclature/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-19 20:43:57

@kylacochrane kylacochrane marked this pull request as ready for review June 17, 2024 20:40
@kylacochrane kylacochrane requested a review from apetkau June 17, 2024 20:40
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great Kyla. Thanks so much for your work 😄 . A few comments for you.

CHANGELOG.md Outdated Show resolved Hide resolved
workflows/gas_nomenclature.nf Outdated Show resolved Hide resolved
tests/pipelines/main_gm_threshold.nf.test Outdated Show resolved Hide resolved
tests/pipelines/main_gm_threshold.nf.test Outdated Show resolved Hide resolved
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much Kyla. This is amazing work 😄

@kylacochrane kylacochrane merged commit 950704c into dev Jun 20, 2024
4 checks passed
@kylacochrane kylacochrane deleted the add_tests branch June 27, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants