Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sistr v1.1.3 new Galaxy wrapper release #268

Merged
merged 16 commits into from
Dec 20, 2024
Merged

Sistr v1.1.3 new Galaxy wrapper release #268

merged 16 commits into from
Dec 20, 2024

Conversation

kbessonov1984
Copy link
Collaborator

This is a new and improved SISTR v1.1.3 Galaxy wrapper that

  • provides support for the new -list-of-serovars option introduced in this release allowing user to use default or custom list of serovars to check SISTR prediction against
  • now all output items in the history get filename added to their name to allow for easier identification especially in cases a History has large items
  • Updated tests to check for the serovar in the list feature

Copy link
Member

@emarinier emarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran it locally through planemo on some test data and didn't see any errors. I'm on vacation for two weeks after today, so I won't be able to approve after further changes. Might want to ask @apetkau to give it a final look over later.

tools/sistr_cmd/.shed.yml Outdated Show resolved Hide resolved
tools/sistr_cmd/sistr_cmd.xml Show resolved Hide resolved
tools/sistr_cmd/sistr_cmd.xml Outdated Show resolved Hide resolved
tools/sistr_cmd/sistr_cmd.xml Outdated Show resolved Hide resolved
@kbessonov1984
Copy link
Collaborator Author

completed all requests

Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much.

@apetkau apetkau merged commit 4a9d0e7 into master Dec 20, 2024
10 checks passed
@apetkau apetkau deleted the sistr branch December 20, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants