Merge pull request #137 from pfpack/release/2.2.0-preview.9_failure-t…

…ests release/2.2.0-preview.9_failure-tests
pfpack · Feb 11, 2024 · 2b0e21c · 2b0e21c
2 parents 669d4af + 2200ba9
commit 2b0e21c
Show file tree

Hide file tree

Showing 26 changed files with 40 additions and 93 deletions.
diff --git a/src/core-taggeds-failure/Failure.Tests/AssertHelper/AssertHelper.cs b/src/core-taggeds-failure/Failure.Tests/AssertHelper/AssertHelper.cs
@@ -1,17 +1,16 @@
 using System;
-using Xunit;
-
-namespace PrimeFuncPack.Core.Tests;
-
-internal static class AssertHelper
-{
-    public static void AssertEqualFailures<TFailureCode>(
-        (TFailureCode FailureCode, string FailureMessage, Exception? SourceException) expected,
-        (TFailureCode FailureCode, string FailureMessage, Exception? SourceException) actual)
-        where TFailureCode : struct
-    {
-        Assert.StrictEqual(expected.FailureCode, actual.FailureCode);
-        Assert.Equal(expected.FailureMessage, actual.FailureMessage);
-        Assert.Equal(expected.SourceException, actual.SourceException);
-    }
-}
+
+namespace PrimeFuncPack.Core.Tests;
+
+internal static class AssertHelper
+{
+    internal static void AssertEqualFailures<TFailureCode>(
+        (TFailureCode FailureCode, string FailureMessage, Exception? SourceException) expected,
+        (TFailureCode FailureCode, string FailureMessage, Exception? SourceException) actual)
+        where TFailureCode : struct
+    {
+        Assert.StrictEqual(expected.FailureCode, actual.FailureCode);
+        Assert.Equal(expected.FailureMessage, actual.FailureMessage);
+        Assert.Same(expected.SourceException, actual.SourceException);
+    }
+}
diff --git a/src/core-taggeds-failure/Failure.Tests/GlobalUsings.cs b/src/core-taggeds-failure/Failure.Tests/GlobalUsings.cs
@@ -0,0 +1 @@
+global using Xunit;
diff --git a/src/core-taggeds-failure/Failure.Tests/Source/FailureTestSource.cs b/src/core-taggeds-failure/Failure.Tests/Source/FailureTestSource.cs
@@ -6,10 +6,6 @@ internal static partial class FailureTestSource
 {
     private sealed class SomeException : Exception
     {
-        public static readonly SomeException SomeInstance;
-
-        static SomeException()
-            =>
-            SomeInstance = new();
+        internal static SomeException Instance { get; } = new();
     }
 }
diff --git a/src/core-taggeds-failure/Failure.Tests/Source/Source.Equal.cs b/src/core-taggeds-failure/Failure.Tests/Source/Source.Equal.cs
@@ -1,78 +1,67 @@
 using System;
-using System.Collections.Generic;
 using PrimeFuncPack.UnitTest;
 
 namespace PrimeFuncPack.Core.Tests;
 
 partial class FailureTestSource
 {
-    public static IEnumerable<object[]> EqualPairTestData
+    public static TheoryData<Failure<EnumType>, Failure<EnumType>> EqualPairTestData
         =>
-        new[]
+        new()
         {
-            new object[]
             {
                 new Failure<EnumType>(),
-                default(Failure<EnumType>)
+                default
             },
-            new object[]
             {
                 new Failure<EnumType>(),
                 new Failure<EnumType>(default, null)
             },
-            new object[]
             {
-                default(Failure<EnumType>),
+                default,
                 new Failure<EnumType>(default, string.Empty)
                 {
                     SourceException = null
                 }
             },
-            new object[]
             {
                 new Failure<EnumType>(default, null),
                 new Failure<EnumType>()
             },
-            new object[]
             {
                 new Failure<EnumType>(default, string.Empty),
-                default(Failure<EnumType>)
+                default
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, null)
                 {
-                    SourceException = SomeException.SomeInstance
+                    SourceException = SomeException.Instance
                 },
                 new Failure<EnumType>(EnumType.One, null)
                 {
-                    SourceException = SomeException.SomeInstance
+                    SourceException = SomeException.Instance
                 }
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Two, string.Empty),
                 new Failure<EnumType>(EnumType.Two, null)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Three, null),
                 new Failure<EnumType>(EnumType.Three, string.Empty)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Zero, string.Empty),
                 new Failure<EnumType>(EnumType.Zero, string.Empty)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, TestData.SomeString)
                 {
-                    SourceException = SomeException.SomeInstance
+                    SourceException = SomeException.Instance
                 },
                 new Failure<EnumType>(EnumType.One, TestData.SomeString)
                 {
-                    SourceException = SomeException.SomeInstance
+                    SourceException = SomeException.Instance
                 }
             }
         };

diff --git a/src/core-taggeds-failure/Failure.Tests/Source/Source.ToException.cs b/src/core-taggeds-failure/Failure.Tests/Source/Source.ToException.cs
@@ -1,66 +1,56 @@
 using System;
-using System.Collections.Generic;
 using System.Reflection;
 using PrimeFuncPack.UnitTest;
 
 namespace PrimeFuncPack.Core.Tests;
 
 partial class FailureTestSource
 {
-    public static IEnumerable<object[]> ToExceptionTestData
+    public static TheoryData<Failure<EnumType>, Failure<EnumType>.Exception> ToExceptionTestData
         =>
-        new[]
+        new()
         {
-            new object[]
             {
-                default(Failure<EnumType>),
+                default,
                 InnerCreate(default(EnumType), null, null)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, null),
                 InnerCreate(EnumType.One, null, null)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Two, string.Empty),
                 InnerCreate(EnumType.Two, null, null)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Zero, TestData.WhiteSpaceString),
                 InnerCreate(EnumType.Zero, TestData.WhiteSpaceString, null)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Two, TestData.SomeString),
                 InnerCreate(EnumType.Two, TestData.SomeString, null)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Three, null)
                 {
                     SourceException = new InvalidOperationException("Some error message")
                 },
                 InnerCreate(EnumType.Three, null, new InvalidOperationException("Some error message"))
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, string.Empty)
                 {
                     SourceException = new("Some Exception")
                 },
                 InnerCreate(EnumType.One, null, new("Some Exception"))
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, TestData.MixedWhiteSpacesString)
                 {
                     SourceException = new("Some Exception")
                 },
                 InnerCreate(EnumType.One, TestData.MixedWhiteSpacesString, new("Some Exception"))
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Two, TestData.AnotherString)
                 {
@@ -78,9 +68,9 @@ private static Failure<TFailureCode>.Exception InnerCreate<TFailureCode>(
 
         var constructor = typeof(Failure<TFailureCode>.Exception).GetConstructor(
             bindingAttr: BindingFlags.NonPublic | BindingFlags.Instance,
-            types: new[] { typeof(TFailureCode), typeof(string), typeof(Exception) })
+            types: [typeof(TFailureCode), typeof(string), typeof(Exception)])
             ?? throw new InvalidOperationException($"Required constructor in type {type} was not found");
 
-        return (Failure<TFailureCode>.Exception)constructor.Invoke(new object?[] { failureCode, message, innerException });
+        return (Failure<TFailureCode>.Exception)constructor.Invoke([failureCode, message, innerException]);
     }
 }
diff --git a/src/core-taggeds-failure/Failure.Tests/Source/Source.Unequal.cs b/src/core-taggeds-failure/Failure.Tests/Source/Source.Unequal.cs
@@ -1,52 +1,44 @@
 using System;
-using System.Collections.Generic;
 using PrimeFuncPack.UnitTest;
 
 namespace PrimeFuncPack.Core.Tests;
 
 partial class FailureTestSource
 {
-    public static IEnumerable<object[]> UnequalPairTestData
+    public static TheoryData<Failure<EnumType>, Failure<EnumType>> UnequalPairTestData
         =>
-        new[]
+        new()
         {
-            new object[]
             {
                 new Failure<EnumType>(),
                 new Failure<EnumType>(EnumType.One, null)
             },
-            new object[]
             {
-                default(Failure<EnumType>),
+                default,
                 new Failure<EnumType>(EnumType.Two, TestData.WhiteSpaceString)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.Three, null),
-                default(Failure<EnumType>)
+                default
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, TestData.TabString),
                 new Failure<EnumType>()
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, TestData.SomeString),
                 new Failure<EnumType>(EnumType.Two, TestData.SomeString)
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, TestData.SomeString)
                 {
-                    SourceException = SomeException.SomeInstance
+                    SourceException = SomeException.Instance
                 },
                 new Failure<EnumType>(EnumType.One, TestData.UpperSomeString)
                 {
-                    SourceException = SomeException.SomeInstance
+                    SourceException = SomeException.Instance
                 }
             },
-            new object[]
             {
                 new Failure<EnumType>(EnumType.One, TestData.SomeString)
                 {

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Deconstruct.Exception.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Deconstruct.Exception.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.Core.Tests.AssertHelper;
 using static PrimeFuncPack.UnitTest.TestData;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Deconstruct.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Deconstruct.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.Core.Tests.AssertHelper;
 using static PrimeFuncPack.UnitTest.TestData;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Equality.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Equality.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 
 namespace PrimeFuncPack.Core.Tests;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Inequality.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Inequality.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 
 namespace PrimeFuncPack.Core.Tests;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Object.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Object.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 
 namespace PrimeFuncPack.Core.Tests;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Other.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Other.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 
 namespace PrimeFuncPack.Core.Tests;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Static.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Equals.Static.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 
 namespace PrimeFuncPack.Core.Tests;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Exception.To.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Exception.To.cs
@@ -1,7 +1,6 @@
 using System;
 using DeepEqual.Syntax;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 
 namespace PrimeFuncPack.Core.Tests;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Factory.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.Factory.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.Core.Tests.AssertHelper;
 using static PrimeFuncPack.UnitTest.TestData;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.FailureCode.Map.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.FailureCode.Map.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.Core.Tests.AssertHelper;
 using static PrimeFuncPack.UnitTest.TestData;
 

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.FailureCode.With.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.FailureCode.With.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.Core.Tests.AssertHelper;
 
 namespace PrimeFuncPack.Core.Tests;

diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.GetHashCode.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.GetHashCode.cs
@@ -1,6 +1,5 @@
 using System;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.UnitTest.TestData;
 
 namespace PrimeFuncPack.Core.Tests;
@@ -15,7 +14,7 @@ public static void GetHashCode_FirstIsEqualToSecondAndTypesAreSame_ExpectHashCod
         var firstHashCode = first.GetHashCode();
         var secondHashCode = second.GetHashCode();
 
-        Assert.Equal(firstHashCode, secondHashCode);
+        Assert.StrictEqual(firstHashCode, secondHashCode);
     }
 
     [Fact]
@@ -27,7 +26,7 @@ public static void GetHashCode_FirstTypeIsNotEqualToSecondType_ExpectHashCodesAr
         var firstHashCode = first.GetHashCode();
         var secondHashCode = second.GetHashCode();
 
-        Assert.NotEqual(firstHashCode, secondHashCode);
+        Assert.NotStrictEqual(firstHashCode, secondHashCode);
     }
 
     [Theory]
@@ -38,6 +37,6 @@ public static void GetHashCode_FirstIsNotEqualToSecondAndTypesAreSame_ExpectHash
         var firstHashCode = first.GetHashCode();
         var secondHashCode = second.GetHashCode();
 
-        Assert.NotEqual(firstHashCode, secondHashCode);
+        Assert.NotStrictEqual(firstHashCode, secondHashCode);
     }
 }
diff --git a/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.ToString.cs b/src/core-taggeds-failure/Failure.Tests/Test.Failure/Test.ToString.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Globalization;
 using PrimeFuncPack.UnitTest;
-using Xunit;
 using static PrimeFuncPack.UnitTest.TestData;
 
 namespace PrimeFuncPack.Core.Tests;