Added examples of subPath volume mount with fuse sidecar
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everpeace
changed the title
subpath with fuse sidecar examplessubPath volume mount with fuse sidecar
everpeace
force-pushed
the
subpath-requires-sidecar
branch
from
d14de24 to
836a076
Compare
|
Thanks! |
everpeace
commented
Sep 6, 2024
| $(eval $(call test-example-template,proxy,sshfs,deploy.yaml,starter,/root/sshfs-example/subdir/test.txt,busybox,/data/subdir/test.txt)) | ||
| $(eval $(call test-example-template,starter,ros3fs,deploy.yaml,starter,/test.txt,busybox,/data/subdir/test.txt)) | ||
| $(eval $(call test-example-template,starter,sshfs,deploy.yaml,starter,/root/sshfs-example/subdir/test.txt,busybox,/data/subdir/test.txt)) | ||
| ifdef TEST_SUBPATH |
There was a problem hiding this comment.
Shall we test subpath volumes in Github Actions?
The default kind version in the Github-Hosted runner(ubuntu-latest) already supports sidecar containers .
There was a problem hiding this comment.
Of course, thanks!
BTW: It would be better to recommend users to use sidecar container as a default usage.
There was a problem hiding this comment.
OK. I will create another PR for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, kubernetes v1.30 supports sidecar containers(a.k.a. restartable init containers) by default. It don't needs for application containers to wait fuse mount is finished manually.
This PR adds:
subPathmount examples and testssubPathvolume may be created by kubelet before the fuse is mounted to the prepared mountpoint, sidecar is must for usingsubPathvolume mount.NOICEsection to describe these.