Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save and load methods for coupling element #1141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jguarato
Copy link
Contributor

@jguarato jguarato commented Jan 21, 2025

Fixes #1135


Note:

  • Some tests were included for the CouplingElement in test_shaft_element.py
  • The use of the CouplingElement was also included in the ShaftElement class part of the ROSS tutorial.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (f1bba84) to head (dac2556).
Report is 66 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1141      +/-   ##
==========================================
+ Coverage   81.67%   82.75%   +1.07%     
==========================================
  Files          38       38              
  Lines        8310     8012     -298     
==========================================
- Hits         6787     6630     -157     
+ Misses       1523     1382     -141     
Files with missing lines Coverage Δ
ross/coupling_element.py 84.29% <100.00%> (+70.35%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8df3e1c...dac2556. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to save rotor with coupling element
2 participants