Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ANSI_QUOTES default set on server #139

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Support ANSI_QUOTES default set on server #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions mysql/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,15 @@ func afterConnectVersion(ctx context.Context, mysqlConf *MySQLConfiguration, db
versionMaxExclusive, _ := version.NewVersion("8.0.0")
if currentVersion.GreaterThanOrEqual(versionMinInclusive) &&
currentVersion.LessThan(versionMaxExclusive) {
// CONCAT and setting works even if there is no value.
_, err = db.ExecContext(ctx, `SET SESSION sql_mode=CONCAT(@@sql_mode, ',NO_AUTO_CREATE_USER')`)
// We set NO_AUTO_CREATE_USER to prevent provider from creating user when creating grants. Newer MySQL has it automatically.
// We don't want any other modes, esp. not ANSI_QUOTES.
_, err = db.ExecContext(ctx, `SET SESSION sql_mode='NO_AUTO_CREATE_USER'`)
if err != nil {
return nil, fmt.Errorf("failed setting SQL mode: %v", err)
}
} else {
// We don't want any modes, esp. not ANSI_QUOTES.
_, err = db.ExecContext(ctx, `SET SESSION sql_mode=''`)
if err != nil {
return nil, fmt.Errorf("failed setting SQL mode: %v", err)
}
Expand Down
Loading