Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Allow container bindings for http classes (laravel arch preset) #1332

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

ol1s
Copy link

@ol1s ol1s commented Dec 24, 2024

What:

  • Bug Fix

Description:

Current Laravel arch preset only allows App\Http classes to be used within App\Http.

This makes sense MOST of the time.

But feels reasonable to accept that container bindings for controllers/middleware CAN be manually registered in service providers eg. primitives https://laravel.com/docs/11.x/container#binding-primitives

This means App\Http also needs to be usable in App\Providers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant