Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update deprecated <coverage> config usage #241

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Nov 7, 2023

Closes #240

@secondmanveran
Copy link

@owenvoke

How does this resolve the coverage issue? This page is about coverage, not source.

@owenvoke
Copy link
Member Author

owenvoke commented Nov 7, 2023

<source> is the replacement for determining which files to cover. Coverage now uses the include / exclude directories from <source>, rather than <coverage>.

@secondmanveran
Copy link

Gotcha.

There is still a coverage tag with props passed in that you may want to reference or maybe include a link to the docs.

And you're saying the I can still run a coverage report with no coverage tag in the xml file, and just move my includes and excludes to my source tag?

@owenvoke
Copy link
Member Author

owenvoke commented Nov 7, 2023

Yes, coverage will still work without the <coverage> tag, that's just for configuring additional things like path coverage and report paths.

asciicast

@nunomaduro nunomaduro merged commit 262482a into master Nov 7, 2023
2 checks passed
@nunomaduro nunomaduro deleted the bugfix/coverage-xml branch November 7, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Coverage Section Incorrect for PHPUnit 10
3 participants