-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix choice indent #16
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,4 +7,29 @@ arguments = { | |
} | ||
blah = { | ||
("w") ~ &("z") | ||
} | ||
|
||
// https://github.com/pest-parser/pest-fmt/issues/15 | ||
log_line1 = { | ||
"0" ~ ("1" // a comment | ||
| "2" // another comment | ||
| "3" // longer comment | ||
| "4" // final comment | ||
| "a" | "b" | "c" | "d") | ||
} | ||
|
||
log_line2 = { | ||
"0" ~ ("0" // a comment | ||
| "0" // another comment | ||
| "1" // longer comment | ||
| "2" // final comment | ||
| "a" | "b" | "c" | "d" | "e") | ||
} | ||
|
||
log_line3 = { | ||
// lead comment | ||
"1" ~ ("2" // another comment | ||
| "3" // longer comment | ||
| "4" // final comment | ||
| "5" | "a" | "b" | "c" | "d" | "e") // comment | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. will this split up the choices if there was more of them, so that it is not too long vertically?
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if correct to align the comment like that -- the original feedback was that the intention was to put the "final comment" on top of "a" (or "5" in log_line3), but formatting makes it look like that it's attached to the previous line ("4" instead of "a" or "5")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't try to improve the comment style for this case, but focused on ensuring alignment and avoiding loss.