cr-01-06-2023 #35
Open
cr-01-06-2023 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… entity i do wspólnego dla userów, walidacja danych wejściowych gotowa
rejestracja pojedynczego Hr'a i listy użytkowników, zapis do osobnych…
…gister # Conflicts: # .gitignore # package-lock.json # package.json # src/app.module.ts # src/main.ts
#27-entities # Conflicts: # src/entities/Student.entity.ts
…e to many ze studentami :D.
…jedynczego usera (HR)
Entities i relacje w bazie danych/ # 27
…ail, a pozostałe dodawało, działa ale obsługa błędów jest beznadziejna i jak doda użytkownika to zwraca błąd, w sensie nie mogłem zwrócić w inny sposób komunikatu o tym kto został dodany ( chyba że to zbędne, to wywale )
Zmiany w pobieraniu cv studenta dla HR
…-from-develop Feature/#76 filtering data branch from develop
update Readme
Fix max reserved students
…udent. Change functions order, so student status won't be changed, when recruiter has reached maximum reserved students.
…ents filtering options.
…nts filtering options.
…ering Feature/#96 change salary in filtering
…-fix Feature/#95 change student status fix
added mail templates, and updated
Development
Ami777
commented
Jun 1, 2023
|
|
||
| Nest is [MIT licensed](LICENSE). | ||
| <p align="right">(<a href="#readme-top">back to top</a>)</p> |
|
|
||
| JWT_SECRET: process.env['JWT_SECRET'], | ||
| JWT_EXPIRES_ACCESS: process.env['JWT_EXPIRES_ACCESS'], | ||
| JWT_EXPIRES_REFRESH: process.env['JWT_EXPIRES_REFRESH'], |
There was a problem hiding this comment.
Klasa. Brawa za użycie env.
Tylko czy mi się wydaje czy brakuje przykładowego pliku evn?
| Score3 = 3, | ||
| Score4 = 4, | ||
| Score5 = 5, | ||
| } |
There was a problem hiding this comment.
Pytanie czy to ma sens?
| Score5 = 5, | ||
| } | ||
|
|
||
| export enum StudentStatus { |
There was a problem hiding this comment.
Takie typy raczej dobrze przenieść do folderu typów.
| </tr> | ||
| </table> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Klasa, brawo za użycie ejs.
| studentProfile.user = user; | ||
| checkLinksToGithub(row.bonusProjectUrls); | ||
| studentProfile.bonusProjectUrls = row.bonusProjectUrls; | ||
| checkGrade(row.courseCompletion); |
There was a problem hiding this comment.
Pytanie czy tego by się nie dało DTO jakoś ograć?
|
Dzięki za CR @Ami777 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.