Fix for validate_refs that says hosts are not valid if they are an em…

…pty object
perfsonar · Jun 21, 2024 · 1e52c4c · 1e52c4c
1 parent 09aeb74
commit 1e52c4c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/psconfig/perfsonar-psconfig/psconfig/client/psconfig/base_node.py b/psconfig/perfsonar-psconfig/psconfig/client/psconfig/base_node.py
@@ -718,7 +718,9 @@ def _validate_urlhostport(self, val=None):
         return False
 
     def _has_field(self, parent, field):
-        return parent.get(field)
+        if parent.get(field) is None:
+            return False
+        return True
 
     def _init_field(self, parent, field):
         if not self._has_field(parent, field):

diff --git a/psconfig/perfsonar-psconfig/psconfig/client/psconfig/config.py b/psconfig/perfsonar-psconfig/psconfig/client/psconfig/config.py
@@ -252,7 +252,7 @@ def validate_refs(self):
             host_ref = address.host_ref()
             context_refs = address.context_refs()
             #check host ref
-            if host_ref and not self.host(host_ref):
+            if host_ref and self.host(host_ref) is None:
                 ref_errors.append("Address {} references a host object {} that does not exist.".format(addr_name, host_ref))
 
             #check context refs