Skip to content
This repository has been archived by the owner on Jan 15, 2025. It is now read-only.

PMM-12422-exporters-bind-push-mode #1168

Merged
merged 15 commits into from
Nov 24, 2023
Merged

PMM-12422-exporters-bind-push-mode #1168

merged 15 commits into from
Nov 24, 2023

Conversation

rasika-chivate
Copy link
Collaborator

@render
Copy link

render bot commented Oct 18, 2023

Your Render PR Server URL is https://pmm-release-branch-pr-1168.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cknnjl9rfc9c73b6g1ag.

@rasika-chivate rasika-chivate marked this pull request as ready for review October 18, 2023 07:07
rnovikovP
rnovikovP suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@rnovikovP rnovikovP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. it's a little confusing to have different explanations for the same flag. is it really working differently based on agent or admin usage?
  2. "0.0.0.0 address" vs "127.0.0.1" explanation is very technical. Can we have a human-friendly one? To explain what this will cause for the user.

@idoqo idoqo self-requested a review November 16, 2023 11:22
idoqo
idoqo reviewed Nov 22, 2023
View reviewed changes
docs/details/commands/pmm-admin.md Outdated
@@ -77,6 +77,9 @@ PMM communicates with the PMM Server via a PMM agent process.
`--group=<group-name>`
: Group name for external services. Default: `external`

`--expose-exporter-address` (This flag is availble starting with PMM 2.41.0.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`--expose-exporter-address` (This flag is availble starting with PMM 2.41.0.)
`--expose-exporter` (This flag is availble starting with PMM 2.41.0.)

We figured --expose-exporter-address felt too long, so we went with --expose-exporter

docs/details/commands/pmm-admin.md Outdated Show resolved Hide resolved
docs/details/commands/pmm-agent.md Outdated
@@ -64,6 +64,8 @@ Most options can be set via environment variables (shown in parentheses).
| `--trace` | `PMM_AGENT_TRACE` | Enable trace output (implies `--debug`).
| `-h`, `--help` | | Show help (synonym for `pmm-agent help`).
| `--version` | | Show application version, PMM version, time-stamp, git commit hash and branch.
| `--expose-exporter-address` (This flag is available starting with PMM 2.41.0.)| | If you enable this flag, any IP address on the local network and anywhere on the internet can access node exporter endpoints. If the flag is disabled, node exporter endpoints can be accessed only locally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `--expose-exporter-address` (This flag is available starting with PMM 2.41.0.)| | If you enable this flag, any IP address on the local network and anywhere on the internet can access node exporter endpoints. If the flag is disabled, node exporter endpoints can be accessed only locally.
| `--expose-exporter` (This flag is available starting with PMM 2.41.0.)| | If you enable this flag, any IP address on the local network and anywhere on the internet can access node exporter endpoints. If the flag is disabled, node exporter endpoints can be accessed only locally.

rnovikovP
rnovikovP approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@rnovikovP rnovikovP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with @idoqo comment re default value

@rasika-chivate rasika-chivate requested a review from idoqo November 24, 2023 08:04
@rasika-chivate rasika-chivate merged commit 084ff06 into PMM_2.41.0 Nov 24, 2023
1 check passed
@rasika-chivate rasika-chivate deleted the PMM-12422-exporters-bind-push-mode branch November 24, 2023 08:08
rasika-chivate added a commit that referenced this pull request Dec 12, 2023
@rasika-chivate @ademidoff
@alina-derkach-oaza @catalinaadam @JiriCtvrtka @idoqo @BupycHuk
PMM release 2.41.0 (#1157)
d00a88b 
* PMM release 2.41.0

* PMM-12375 db ver details inventory services (#1162)

* PMM-12375-db-ver-details-inventory-services

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update docs/details/dashboards/dashboard-inventory.md

Co-authored-by: Alex Demidoff <[email protected]>

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update advisors.md

* Update advisors.md

* Update docs/details/dashboards/dashboard-inventory.md

Co-authored-by: Alex Demidoff <[email protected]>

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* Update dashboard-inventory.md

---------

Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alina Derkach <[email protected]>

* PMM Dump info

* added link with instructions for SFTP credentials

* PMM-12544 : DbaaS warning (#1165)

* PMM-12544

* added warning notes

* updated links

* Feedback from Artem

* PMM-12597

* feedback from Nurlan

* PMM-11341-autodiscovery-postgres (#1174)

* PMM-11341-autodiscovery-postgres

* Update postgresql.md

* add image for auto-discovery

* automatic discovery via CLI

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Updated the image

* Added images

* Update postgresql.md

* updated the image

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

* Update docs/setting-up/client/postgresql.md

Co-authored-by: Jiří Čtvrtka <[email protected]>

* Update postgresql.md

* Update postgresql.md

* Update postgresql.md

---------

Co-authored-by: Jiří Čtvrtka <[email protected]>

* PMM-12422-exporters-bind-push-mode (#1168)

* PMM-12422-exporters-bind-push-mode

* Update pmm-admin.md

* Update pmm-agent.md

* Update pmm-agent.md

* Update pmm-admin.md

* Update pmm-agent.md

* Update pmm-admin.md

* Update docs/details/commands/pmm-agent.md

Co-authored-by: Michael Okoko <[email protected]>

* Update docs/details/commands/pmm-admin.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Update pmm-admin.md

* Update pmm-agent.md

* changed the falg name as per feedback

* Update pmm-agent.md

* Update docs/details/commands/pmm-admin.md

Co-authored-by: Michael Okoko <[email protected]>

---------

Co-authored-by: Michael Okoko <[email protected]>
Co-authored-by: Nurlan Moldomurov <[email protected]>

* PMM-12476-cluster-view-search (#1176)

* PMM-12476-cluster-view-search

* Update dashboard-inventory.md

* Update dashboard-inventory.md

* mentioned the standalone  dump utility

* RN_2.41.0 trigger the build

* Fix the emoji extension

* Revert - fix the emoji extension

* Release_Notes_2.41.0_base_change (#1179)

* PMM-12078 HA in PMM (#1172)

* Pmm 12078 HA in PMM

* importance of HA

* Update HA.md

* Procedure to set up PMM in HA mode

* Update HA.md

* Update mkdocs-base.yml

* added HA.md in correct folder

* Update HA.md

* added step 1

* created step 2

* added step 3

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update mkdocs-base.yml

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update HA.md

* Update docs/get-started/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* added disclaimer for Technical preview

* Update HA.md

* added a note

* Update docs/get-started/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Update docs/get-started/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Moved this section into a different folder as per feedback

* implemented feedback from nailya

* Update HA.md

* Update docs/details/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Update docs/details/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Update docs/details/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Update docs/details/HA.md

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Update HA.md

* implement feedback

* Implemented feedback

* Update mkdocs-base.yml

* Moved HA topic to how-to

* Update index.md

* Update HA.md

* Implemented feedback

* Implemented the feedback from Santo

---------

Co-authored-by: Nurlan Moldomurov <[email protected]>

* Added RN to this branch

* fixed notes

* fix note

* Implement the feedback from Santo

* Update 2.41.0.md

* Update 2.41.0.md

* Update 2.41.0.md

* Update 2.41.0.md

* Update 2.41.0.md

* Update mkdocs-base.yml

* Update query-analytics.md

* revert_changes_from-2.41.0 (#1182)

* revert_changes_from-2.41.0

* Update 2.41.0.md

* formatting

* revert changes for PMM-8655

* removed quickstart file

---------

Co-authored-by: Catalina A <[email protected]>

* Update mkdocs-base.yml

* Update variables.yml

* Update mkdocs-base.yml

* Update 2.41.0.md

---------

Co-authored-by: Alex Demidoff <[email protected]>
Co-authored-by: Alina Derkach <[email protected]>
Co-authored-by: Catalina A <[email protected]>
Co-authored-by: Catalina A <[email protected]>
Co-authored-by: Jiří Čtvrtka <[email protected]>
Co-authored-by: Michael Okoko <[email protected]>
Co-authored-by: Nurlan Moldomurov <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BupycHuk BupycHuk BupycHuk approved these changes

@idoqo idoqo idoqo approved these changes

@rnovikovP rnovikovP rnovikovP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rasika-chivate @BupycHuk @idoqo @rnovikovP