Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPXC-1546: Cache binlog->gtid set pairs #1959
K8SPXC-1546: Cache binlog->gtid set pairs #1959
Changes from all commits
1794cd4
01212c0
32cb0c0
2ba4b02
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check notice on line 44 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L44 <ShellCheck.SC2086>
Raw output
Check warning on line 63 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L63 <ShellCheck.SC1090>
Raw output
Check warning on line 256 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L256 <ShellCheck.SC2124>
Raw output
Check warning on line 266 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L266 <ShellCheck.SC2124>
Raw output
Check notice on line 267 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L267 <ShellCheck.SC2086>
Raw output
Check notice on line 267 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L267 <ShellCheck.SC2086>
Raw output
Check warning on line 308 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L308 <ShellCheck.SC2166>
Raw output
Check warning on line 321 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L321 <ShellCheck.SC2166>
Raw output
Check warning on line 321 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L321 <ShellCheck.SC2166>
Raw output
Check notice on line 377 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L377 <ShellCheck.SC2236>
Raw output
Check notice on line 385 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L385 <ShellCheck.SC2236>
Raw output
Check warning on line 385 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L385 <ShellCheck.SC2166>
Raw output
Check notice on line 442 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L442 <ShellCheck.SC2236>
Raw output
Check warning on line 456 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L456 <ShellCheck.SC2166>
Raw output
Check notice on line 474 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L474 <ShellCheck.SC2236>
Raw output
Check notice on line 491 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L491 <ShellCheck.SC2236>
Raw output
Check warning on line 497 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L497 <ShellCheck.SC2166>
Raw output
Check notice on line 512 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L512 <ShellCheck.SC2002>
Raw output
Check warning on line 518 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L518 <ShellCheck.SC2053>
Raw output
Check notice on line 525 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L525 <ShellCheck.SC2236>
Raw output
Check warning on line 555 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L555 <ShellCheck.SC2166>
Raw output
Check notice on line 560 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L560 <ShellCheck.SC2002>
Raw output
Check warning on line 564 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L564 <ShellCheck.SC2166>
Raw output
Check warning on line 579 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L579 <ShellCheck.SC2166>
Raw output
Check notice on line 583 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L583 <ShellCheck.SC2002>
Raw output
Check notice on line 620 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L620 <ShellCheck.SC2086>
Raw output
Check notice on line 673 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L673 <ShellCheck.SC1091>
Raw output
Check notice on line 681 in build/pxc-entrypoint.sh
[shellcheck] build/pxc-entrypoint.sh#L681 <ShellCheck.SC2086>
Raw output
Check warning on line 12 in build/wsrep_cmd_notify_handler.sh
[shellcheck] build/wsrep_cmd_notify_handler.sh#L12 <ShellCheck.SC2034>
Raw output
Check warning on line 16 in build/wsrep_cmd_notify_handler.sh
[shellcheck] build/wsrep_cmd_notify_handler.sh#L16 <ShellCheck.SC2034>
Raw output
Check warning on line 20 in build/wsrep_cmd_notify_handler.sh
[shellcheck] build/wsrep_cmd_notify_handler.sh#L20 <ShellCheck.SC2034>
Raw output
Check warning on line 24 in build/wsrep_cmd_notify_handler.sh
[shellcheck] build/wsrep_cmd_notify_handler.sh#L24 <ShellCheck.SC2034>
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[shfmt] reported by reviewdog 🐶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we going to keep all these logging or do we have them for now only for debugging purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i intend to keep these logs, yes