-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace typo NAMESPASE with NAMESPACE #1949
base: main
Are you sure you want to change the base?
Conversation
@@ -279,7 +279,7 @@ func (c *Node) LogCollectorContainer(spec *api.LogCollectorSpec, logPsecrets str | |||
Value: "/var/lib/mysql", | |||
}, | |||
{ | |||
Name: "POD_NAMESPASE", | |||
Name: "POD_NAMESPACE", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franklouwers thank you for PR! but we can remove these var only for crVersion >= 1.20.0 like https://github.com/percona/percona-xtradb-cluster-operator/pull/1949/files#diff-4c64a958f53a8f3616564c42beb08dfeeaee83a9ae0a13dab3a41cb375998748L407
We need to have it to avoid cluster restart as soon as you update operator image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hors I am sorry, I have no idea how to do that. I don't know (nor really want to know) how the operator works. I've opened an issue for an embarrassing typo that got in, about 3 months ago. Last week you asked me to prep a PR. I just did.
As the typo is in an envvar, which will force a restart, then yes, I assume it will restart. If there's a mechanism to prevent that, I don't know how to do that. It doesn't seem to be in the public documentation.
You mention crVersion: I see it's currently 1.17.0. Should I just change that to 1.20.0 in all places? Why 1.20 btw and not 1.18?
commit: 00b60e7 |
replace typo NAMESPASE with NAMESPACE
Problem:
One of the ENVVARs set by the operator is the POD_NAMESPASE envvar, which contains the namespace the pod is deployed to.
For correct spelling and consistency, this should be POD_NAMESPACE instead
Closes #1865
Cause:
Likely a typo.
Solution:
Fix the typo.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability