Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace typo NAMESPASE with NAMESPACE #1949

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

franklouwers
Copy link

@franklouwers franklouwers commented Jan 22, 2025

replace typo NAMESPASE with NAMESPACE

Problem:
One of the ENVVARs set by the operator is the POD_NAMESPASE envvar, which contains the namespace the pod is deployed to.

For correct spelling and consistency, this should be POD_NAMESPACE instead

Closes #1865

Cause:
Likely a typo.

Solution:
Fix the typo.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@it-percona-cla
Copy link

it-percona-cla commented Jan 22, 2025

CLA assistant check
All committers have signed the CLA.

@pull-request-size pull-request-size bot added the size/L 100-499 lines label Jan 22, 2025
@@ -279,7 +279,7 @@ func (c *Node) LogCollectorContainer(spec *api.LogCollectorSpec, logPsecrets str
Value: "/var/lib/mysql",
},
{
Name: "POD_NAMESPASE",
Name: "POD_NAMESPACE",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@franklouwers thank you for PR! but we can remove these var only for crVersion >= 1.20.0 like https://github.com/percona/percona-xtradb-cluster-operator/pull/1949/files#diff-4c64a958f53a8f3616564c42beb08dfeeaee83a9ae0a13dab3a41cb375998748L407
We need to have it to avoid cluster restart as soon as you update operator image.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hors I am sorry, I have no idea how to do that. I don't know (nor really want to know) how the operator works. I've opened an issue for an embarrassing typo that got in, about 3 months ago. Last week you asked me to prep a PR. I just did.

As the typo is in an envvar, which will force a restart, then yes, I assume it will restart. If there's a mechanism to prevent that, I don't know how to do that. It doesn't seem to be in the public documentation.

You mention crVersion: I see it's currently 1.17.0. Should I just change that to 1.20.0 in all places? Why 1.20 btw and not 1.18?

@JNKPercona
Copy link
Collaborator

Test name Status
affinity-8-0 passed
auto-tuning-8-0 passed
cross-site-8-0 passed
custom-users-8-0 passed
demand-backup-cloud-8-0 passed
demand-backup-encrypted-with-tls-8-0 passed
demand-backup-8-0 passed
haproxy-5-7 passed
haproxy-8-0 passed
init-deploy-5-7 passed
init-deploy-8-0 passed
limits-8-0 passed
monitoring-2-0-8-0 passed
one-pod-5-7 passed
one-pod-8-0 passed
pitr-8-0 passed
pitr-gap-errors-8-0 passed
proxy-protocol-8-0 passed
proxysql-sidecar-res-limits-8-0 passed
pvc-resize-5-7 passed
pvc-resize-8-0 passed
recreate-8-0 passed
restore-to-encrypted-cluster-8-0 passed
scaling-proxysql-8-0 passed
scaling-8-0 passed
scheduled-backup-5-7 passed
scheduled-backup-8-0 passed
security-context-8-0 passed
smart-update1-8-0 passed
smart-update2-8-0 passed
storage-8-0 passed
tls-issue-cert-manager-ref-8-0 passed
tls-issue-cert-manager-8-0 passed
tls-issue-self-8-0 passed
upgrade-consistency-8-0 passed
upgrade-haproxy-5-7 failure
upgrade-haproxy-8-0 failure
upgrade-proxysql-5-7 failure
upgrade-proxysql-8-0 failure
users-5-7 passed
users-8-0 passed
validation-hook-8-0 passed
We run 42 out of 42

commit: 00b60e7
image: perconalab/percona-xtradb-cluster-operator:PR-1949-00b60e7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L 100-499 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POD_NAMESPASE typo
4 participants