EVEREST-1096 | remove the hard-coded resource map for enforcer RBAC #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mayankshah1607
changed the title
mayankshah1607
force-pushed
the
EVEREST-1096.2
branch
from
950d3e0 to
8e794d7
Compare
oksana-grishchenko
approved these changes
Jul 4, 2024
recharte
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This path-resource map, which was earlier hard-coded, was required for enforcing RBAC on the provided API endpoints. The problem with this is that anytime a new API is added, we have to remember to update this map.
With this change, this map is no longer hard-coded, and RBAC may be enforced on API endpoints simply by adding the
x-everest-resource-nameannotation in the swagger spec.