EVEREST-107 remove dead code #1047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
recharte
commented
Jan 23, 2025
•
recharte
commented
pkg/kubernetes/informer/informer.go
Outdated
Comment on lines
102
to
111
| // OnAdd is triggered when an object is added. | ||
| func (i *Informer) OnAdd(cb func(obj interface{})) { | ||
| i.eventHandlers.AddFunc = cb | ||
| } | ||
|
|
||
| // OnDelete is triggered when an object is deleted. | ||
| func (i *Informer) OnDelete(cb func(obj interface{})) { | ||
| i.eventHandlers.DeleteFunc = cb | ||
| } | ||
|
|
There was a problem hiding this comment.
I would actually not remove this, they are a part of the Informer utility. We are currently using only OnUpdate for reloading the RBAC configMap, but it is possible to use OnAdd and onDelete too for other use-cases.
What I mean is this is a generic helper library to watch Kubernetes events and perform actions, so without these 2 methods, the library is kind of incomplete even though we aren't using it anywhere 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.