Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] EVEREST-1647 Restrict selectable hours for PSMDB db with monthly schedule #1009

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

dianabirs
Copy link
Contributor

@dianabirs dianabirs commented Jan 15, 2025

@dianabirs dianabirs requested a review from a team as a code owner January 15, 2025 14:22
@dianabirs dianabirs requested a review from fabio-silva January 22, 2025 11:55
dianabirs and others added 13 commits January 23, 2025 16:51
@dianabirs
Copy link
Contributor Author

added check to only restrict time intervals for AM time values

image

- disable unavailable hours instead of removing them from select
- fix logic for TZ > +12
- add tooltip and help icon for selects with disabled options
@dianabirs
Copy link
Contributor Author

updates:

schedule-update.mov

@dianabirs dianabirs requested a review from fabio-silva January 30, 2025 14:48
@dianabirs dianabirs requested a review from a team as a code owner January 31, 2025 14:25
Comment on lines +19 to +25
- name: Switch docker-daemon data directory to /mnt
run: |
sudo systemctl stop docker
echo '{ "exec-opts": ["native.cgroupdriver=cgroupfs"], "cgroup-parent": "/actions_job", "data-root": "/mnt/docker-data" }' | sudo tee /etc/docker/daemon.json
sudo mkdir /mnt/docker-data
sudo systemctl start docker

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is some sort of speed up, could you please elaborate more on why it's needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see the same step was added in the scope of this PR https://github.com/percona/everest/pull/1074/files with a comment, so now things got more clear. Looks like previously some tests were failing because of running out of space and this change allows to get more space.

percona-robot and others added 2 commits February 3, 2025 13:06
… restrict pm hours if am hours are unavailable, remove edit mode condition
@dianabirs
Copy link
Contributor Author

  • remove editMode condition
  • set time back to first selectable time if AM if selected after changing hour/minute in PM (eg. if selecting 6:20 PM for +5:30 TZ, go back to 5:30 as it is the first selectable time)
  • do not restrict PM hours
tz-fixes.mov

@dianabirs dianabirs requested a review from fabio-silva February 3, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants