[UI] EVEREST-1578 Fix validation for shards for mongodb with more tha…

…n 1 node (#780) * fix: validation for shards for mongo db with more than 1 node * fix: add trigger for nodes changes
percona · Oct 23, 2024 · 261fdba · 261fdba
1 parent 5f77b08
commit 261fdba
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 4 deletions.
diff --git a/ui/apps/everest/src/components/cluster-form/resources/constants.ts b/ui/apps/everest/src/components/cluster-form/resources/constants.ts
@@ -246,11 +246,12 @@ export const resourcesFormSchema = (passthrough?: boolean) => {
         });
       }
 
+      const intNrNodes =
+        numberOfNodes === CUSTOM_NR_UNITS_INPUT_VALUE
+          ? customNrOfNodes
+          : numberOfNodes;
+
       if (dbType === DbType.Mysql) {
-        const intNrNodes =
-          numberOfNodes === CUSTOM_NR_UNITS_INPUT_VALUE
-            ? customNrOfNodes
-            : numberOfNodes;
         const intNrProxies =
           numberOfProxies === CUSTOM_NR_UNITS_INPUT_VALUE
             ? customNrOfProxies
@@ -292,6 +293,13 @@ export const resourcesFormSchema = (passthrough?: boolean) => {
               path: [DbWizardFormFields.shardNr],
             });
           }
+          if (+intNrNodes > 1 && intShardNr < 2) {
+            ctx.addIssue({
+              code: z.ZodIssueCode.custom,
+              message: Messages.sharding.minForNodes,
+              path: [DbWizardFormFields.shardNr],
+            });
+          }
         }
 
         if (

diff --git a/ui/apps/everest/src/components/cluster-form/resources/messages.tsx b/ui/apps/everest/src/components/cluster-form/resources/messages.tsx
@@ -2,6 +2,7 @@ export const Messages = {
   sharding: {
     invalid: 'Please fill in valid values for sharding',
     min: (val: number) => `The value cannot be less than ${val}`,
+    minForNodes: 'The minimum number of shards should be 2',
     max: (val: number) => `The value cannot be more than ${val}`,
     odd: 'The value cannot be even',
     numberOfShards: 'Nº of shards',

diff --git a/ui/apps/everest/src/components/cluster-form/resources/resources.tsx b/ui/apps/everest/src/components/cluster-form/resources/resources.tsx
@@ -512,6 +512,10 @@ const ResourcesForm = ({
     trigger(DbWizardFormFields.shardConfigServers);
   }, [setValue, getFieldState, numberOfNodes, customNrOfNodes]);
 
+  useEffect(() => {
+    trigger();
+  }, [numberOfNodes, customNrOfNodes]);
+
   return (
     <>
       {!!showSharding && !!sharding && (
@@ -523,6 +527,7 @@ const ResourcesForm = ({
           <TextInput
             name={DbWizardFormFields.shardNr}
             textFieldProps={{
+              sx: { maxWidth: '200px' },
               type: 'number',
               required: true,
               inputProps: {