Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python to 3.12 in env #422

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Update python to 3.12 in env #422

merged 4 commits into from
Sep 24, 2024

Conversation

aknierim
Copy link
Member

No description provided.

environment.yml Outdated
@@ -2,7 +2,7 @@ name: toolbox
channels:
- conda-forge
dependencies:
- python=3.11
- python=3.12
- pip
- matplotlib
- numpy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to move to numpy 2 in the same step?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NumPy is already automatically installed as the latest version (2.1.1)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of that. That's why I'm asking - do we want to leave it open?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, we can set it to >=2.0 or ~=2.0... I wouldn't mind 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everything works, I'm fine with it. Just recently had the experience with numpy 2 to be lacking some important "legacy" functions depending on the project.
But if everything we need is also supported, then I'm fine with bumping the version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notebook seems to run fine with NumPy 2

@aknierim aknierim requested a review from SepplL September 24, 2024 09:28
@chrbeckm chrbeckm merged commit 3565dc2 into main Sep 24, 2024
1 check passed
@chrbeckm chrbeckm deleted the update_env branch September 24, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants