Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: readable sync error message #1997

Merged
merged 2 commits into from
Jan 28, 2025
Merged

web: readable sync error message #1997

merged 2 commits into from
Jan 28, 2025

Conversation

TalDerei
Copy link
Contributor

@TalDerei TalDerei commented Jan 26, 2025

Description of Changes

Previously, syncing displayed varying illegible error states (eg. ConnectError and DataCloneError). These can be caused by unstable internet connections, locking the wallet which resets the service worker for security, etc. The error handling has been improved to provide a clearer error message and programmatically reload the page with window.location.reload() every 5s when a sync error occurs.

update: because of the investigation in #1885 (comment), this PR simply just makes the error messaging nicer rather than doing any auto page reloading.

Related Issue

references #1378 and #1898

pairs with prax-wallet/prax#278

Checklist Before Requesting Review

  • I have ensured that any relevant minifront changes do not cause the existing extension to break.

before

Screenshot 2025-01-26 at 12 58 25 PM

after

Screenshot 2025-01-26 at 3 32 04 PM

@TalDerei TalDerei self-assigned this Jan 26, 2025
Copy link

changeset-bot bot commented Jan 26, 2025

⚠️ No Changeset found

Latest commit: d96a7fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TalDerei TalDerei changed the title auto-reload page on sync error web: readable sync error message Jan 26, 2025
@TalDerei TalDerei requested a review from a team January 27, 2025 04:45
@TalDerei TalDerei merged commit 3fc8c91 into main Jan 28, 2025
6 checks passed
@TalDerei TalDerei deleted the auto-reload branch January 28, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants