funding: implement rpc services #5061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
TalDerei
added
the
consensus-breaking
erwanor
approved these changes
Feb 5, 2025
proto/penumbra/penumbra/core/component/funding/v1/funding.proto
Outdated
Show resolved
Hide resolved
proto/penumbra/penumbra/core/component/funding/v1/funding.proto
Outdated
Show resolved
Hide resolved
proto/penumbra/penumbra/core/component/funding/v1/funding.proto
Outdated
Show resolved
Hide resolved
erwanor
reviewed
Feb 5, 2025
TalDerei
commented
Feb 5, 2025
crates/core/component/funding/src/component/liquidity_tournament/nullifier/mod.rs
Show resolved
Hide resolved
|
LGTM, merge on green CI! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
implement funding rpc that allows the client to track whether a nullifier has already been used in the current epoch’s voting period. This isn't a bulk nullifier point query.
Issue ticket number and link
references #5058
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: