funding: mint delegation token lqt rewards #5060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
changed the title
erwanor
force-pushed
the
erwan/mint_delegation_tokens
branch
from
faff411 to
4a2a238
Compare
cronokirby
approved these changes
Feb 6, 2025
| }; | ||
|
|
||
| ensure!( | ||
| !matches!(validator_state, State::Defined | State::Tombstoned), |
There was a problem hiding this comment.
For posterity: we want to allow voting with jailed power, because that validator might be able to recover, right?
There was a problem hiding this comment.
Yes, I think every bonding note is fair game unless the validator is in an irrecoverable state e.g, Tombstoned OR if it is in a precursor state with no resources bound to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a component API to allow
fundingto deposit into a validator's delegation pool. It does so by exposing aValidatorPoolDeposit::deposit_to_validator_poolmethod to safely handle it.One tension in the current design, is that the LQT logic lives in the
fundingcomponent which execute last. As a result, delegation pool increases do not affect the validator's voting power until the following epoch. LQT rewards however, are immediately useful to awardees and can be directed towards future LQT seasons.One notable change to this PR is that we now track voters based on:
Alternative solution
If we want to solve this another way, we could close the current PR, and refactor the LQT logic into its own component. The approach should be the same: the
lqtcomponent calls the safe pool increase handle and thestakingcomponent takes care of the rest.Issue ticket number and link
Discussing and overview in #5046
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: