ci: make workflows runnable ad-hoc #5056
Merged
+20
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to publish the protobuf changes in `protocol/lqt_support` (#5010) to unblock web integrations. In order to run the workflow ad-hoc on a branch, we need to permit `workflow_dispatch` runs. The `workflow_call` additions are not currently used, but have been in the past, and permit triggering via cross-repo API. Also updates the buf lint job to run against *all* PRs, not just those against main. This effectively reverts b3204b1, which is over a year old, and predates the stabilization of the protos.
conorsch
added
the
A-CI/CD
TalDerei
approved these changes
Feb 5, 2025
|
Sadly no, see #1667 for context. Will revisit that issue because it looks like upstream buf tooling may finally support meaningful tags. |
Good news, the buf lint action passes on the latest LQT changes. To test, I branched from
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We want to publish the protobuf changes in
protocol/lqt_support(#5010) to unblock web integrations. In order to run the workflow ad-hoc on a branch, we need to permitworkflow_dispatchruns. Theworkflow_calladditions are not currently used, but have been in the past, and permit triggering via cross-repo API.While authoring these changes, I noticed that the protobuf lint job is not running against feature branches, meaning the PRs into
protocol/lqt_supporthave skipped that check. We've been careful in authoring the proto changes, but we should still verify that check passes on the feature branch, prior to publishing.Issue ticket number and link
Refs #5010.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: