Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump [email protected], [email protected], [email protected] #5055

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SuperFluffy
Copy link
Contributor

@SuperFluffy SuperFluffy commented Feb 5, 2025

Describe your changes

Bump dependencies [email protected], [email protected], [email protected]

Note that this is currently blocked on penumbra-zone/tower-actor#5 being merged so that the patch section in the workspace Cargo.toml can be removed.

tower 0.4.13 still shows up in Cargo.lock as a dependency of [email protected] and [email protected].

[email protected] is already a dependecy in tonic@master as of this PR.

Note for a penumbra-sdk-tower-trace release this constitutes a breaking change (because tower is part of its public API, for example through the trait bount penumbra_sdk_tower_trace::trace:::InstrumentableService where Self::Service).

There are no code level changes and things should just work as-is (unless some runtime level changes in the underlying crates leads to breakage).

Checklist before requesting a review

  • I have added guiding text to explain how a reviewer should test these changes.

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Updating core dependencies to ensure matching semver.

@SuperFluffy
Copy link
Contributor Author

The error points to rand core, which this PR isn't actively touching. I have to take a step back but can look at this later (unless somebody else gets to it who has a better understanding of things).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant