-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lqt(dex): setup volume trackers #5016
Merged
Merged
+310
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
reviewed
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested changes:
- we should go ahead and stream out the volume as well, since we'll need it for correctly allocating rewards.
Suggested refactors:
- use
u16
for epochs, - rely on existing
Position::reserves_for
method to get the reserves for the staking token, and potentially removing the change fortrading_pair.rs
, - restrict the possible changes to the volume to just adding to the tally.
crates/core/component/dex/src/component/position_manager/volume_tracker.rs
Outdated
Show resolved
Hide resolved
crates/core/component/dex/src/component/position_manager/volume_tracker.rs
Show resolved
Hide resolved
Co-authored-by: Lúcás Meier <[email protected]> Signed-off-by: Erwan Or <[email protected]>
cronokirby
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, let's get this merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR:
LqtRead
lqt::v1::lp
andlqt::v1::pair
position_manager::volume_tracker
Volume definition
We track the outflow of staking tokens from the position. This means that an attacker controlled asset must commit to a staking token inventory for at least a full block execution.
State key modeling
The lookup index maps an epoch index and a position id to a cumulative volume tally.
The full sorted index orders position ids by cumulative volume (keyed to the epoch).
Issue ticket number and link
Part of #5015
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
N/A
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: