app: fix broken event indexing #5009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
commented
Jan 28, 2025
erwanor
force-pushed
the
erwan/fix_broken_events
branch
from
eba4324 to
58b4a2c
Compare
|
Great find, and sufficient to resolve the problem reported in #4999. I've tacked on some integration tests for pindexer, off by default, that can be run like so: When running against a full node created from the However when run on this feature branch, they pass: which is exactly what we want to see. Ideally these tests would run in PRs, so we can catch breakage early, but I'll make that change in subsequent PRs, cleaning up the smoke-test logic. This fix is solid and we want it in now! |
Adds some feature-gated integration tests, not yet hooked up to CI,
to sanity check that the ABCI events pipeline is working:
pd -> cometbft -> postgres -> pindexer
The integration tests talk to local postgres databases and make
assertions about their contents. There's also a small change to the
process-compose orchestration, instructing pindexer to wait for the
fullnode services to come up, lest it error out early due to an empty
database. The error I observed on an empty db was:
Error: error occurred while decoding column 0: unexpected null;
try decoding as an `Option`
Caused by:
unexpected null; try decoding as an `Option`
Which is distinct from the error reported in #4999. By waiting
a bit longer we can ensure a clean start even on a fresh devnet.
Will follow up with subsequent PRs to make sure these tests run in CI.
conorsch
approved these changes
Jan 29, 2025
2 tasks
conorsch
added a commit
that referenced
this pull request
Feb 5, 2025
## Describe your changes Follow-up to #5009, in which these tests were introduced, and #5048, which refactored the smoke tests to make additions like this easier. ## Issue ticket number and link See above. ## Testing and review The tests were already merged, this is just enabling them in CI, so CI passing, specifically on the smoke-test job, is enough. ## Checklist before requesting a review - [x] I have added guiding text to explain how a reviewer should test these changes. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > tests/ci only, no changes to application code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We missed this on reviewing #4963 which causes a series of unfortunate events in the data pipeline: #4999
The important diff:
Issue ticket number and link
Checklist before requesting a review
I have not tested this change. To test it we can run
pdand check if events are making it to the comet pg indexer.If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: