view service: add LatestSwaps #5008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
approved these changes
Jan 28, 2025
VanishMax
reviewed
Jan 29, 2025
| &self, | ||
| _request: tonic::Request<pb::LatestSwapsRequest>, | ||
| ) -> Result<tonic::Response<Self::LatestSwapsStream>, tonic::Status> { | ||
| unimplemented!("latest_swaps currently only implemented on web") |
There was a problem hiding this comment.
question: why is it so? I see many methods here are not implemented, is it deliberate?
There was a problem hiding this comment.
question: why is it so? I see many methods here are not implemented, is it deliberate?
we define the rpc service method in view.proto, but we stub the service as unimplemented to ensure the rust build compiles, otherwise it'll complain. In this context, it means that the LatestSwaps view service method is not supported functionality in pcli, but is available in prax (which supports it's own view service implementations).
happy to pair at some point to walk how protobuf + domain type generation + rpc services work in the monorepo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
extends
ViewServiceby adding a newLatestSwapsmethod, enabling clients to query recent swap activity.precursor to penumbra-zone/web#2005
Issue ticket number and link
references penumbra-zone/dex-explorer#320
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: