draft hotfix for chain halt #4995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit posted for testing, commit message + description TK
erwanor
reviewed
Jan 18, 2025
| "attempted to close a position with state {:?}, expected Opened or Closed", | ||
| prev_state.state | ||
| ); | ||
| if prev_state.state == position::State::Opened { |
There was a problem hiding this comment.
ACK, inner logic gated on valid state antecedent.
erwanor
reviewed
Jan 18, 2025
| if prev_state.state == position::State::Closed { | ||
| self.update_position(id, Some(prev_state), new_state) | ||
| .await?; | ||
| self.record_proto(event::EventPositionClose { position_id: *id }.to_proto()); |
There was a problem hiding this comment.
ACK. no change to the inner logic block.
erwanor
reviewed
Jan 18, 2025
| tracing::debug!( | ||
| ?id, | ||
| "position is already closed so we can skip state updates" | ||
| ?prev_state.state, | ||
| "position is not currently open, skipping" |
|
Closing in favor of #4994. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR REVIEW
Commit posted for testing, commit message + description TK
Describe your changes
Issue ticket number and link
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: