pindexer: dex_ex: calculate USDC volume continuously #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
volume-indexing
branch
from
2ff6220 to
4ea2a83
Compare
This adds a field to the low level snapshot used to derive other metrics, which captures the current price of a given asset relative to USDC (configurable to an arbitrary indexing denom). This then allows a pair summary to have a more accurate view of the volume in USDC terms, and for the aggregate summary to thus have a more accurate view. As a side-effect, this also gets rid of liquidity minimums for considering denoms in the aggregate summary.
cronokirby
force-pushed
the
volume-indexing
branch
from
4ea2a83 to
9f04a07
Compare
6 tasks
erwanor
approved these changes
Jan 16, 2025
I haven't done this, I'm merging optimistically, and will reindex when other pindexer changes (e.g. #4990) land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a field to the low level snapshot used to derive other metrics, which captures the current price of a given asset relative to USDC (configurable to an arbitrary indexing denom).
This then allows a pair summary to have a more accurate view of the volume in USDC terms, and for the aggregate summary to thus have a more accurate view.
As a side-effect, this also gets rid of liquidity minimums for considering denoms in the aggregate summary.
To test, run pindexer again, compare the aggregate summary, and then check that the converted volume is about the same.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: