test: add integration tests for https functionality to binaries #4983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to hammer on public endpoints on every test run indefinitely, but given that we're in the midst of a significant refactor, having the new HTTPS-enabled integration tests running in CI will save developer attention by running them automatically.
conorsch
force-pushed
the
testnet-integration
branch
from
d050943 to
7d81d28
Compare
erwanor
approved these changes
Jan 14, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
While working on the tonic version bumps in #4980, we discovered that the HTTPS client support can break without failing CI. This PR builds on the new tests in #4979, trying to establish a baseline sanity check that "yes, the programs can talk to https endpoints" so that during a large refactor, we can easily confirm no regressions.
Issue ticket number and link
Refs
[email protected]#4400Testing and review
Check out this branch, run
just integration-testnetand confirm all checks pass. I also tacked on a commit enabling these new tests in CI, which I consider temporary, but useful for the immediate near-term.It'd also be helpful to point out any places that might use HTTPS clients that aren't covered yet.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: